Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

remoteproc: wkup_m3: Use devm_rproc_add() helper

Use the device lifecycle managed add function. This helps prevent mistakes
like deleting out of order in cleanup functions and forgetting to delete
on error paths.

Signed-off-by: Andrew Davis <afd@ti.com>
Link: https://lore.kernel.org/r/20250814153940.670564-4-afd@ti.com
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>

authored by

Andrew Davis and committed by
Mathieu Poirier
3df0bee9 9b84eec6

+1 -9
+1 -9
drivers/remoteproc/wkup_m3_rproc.c
··· 210 210 211 211 dev_set_drvdata(dev, rproc); 212 212 213 - ret = rproc_add(rproc); 213 + ret = devm_rproc_add(dev, rproc); 214 214 if (ret) 215 215 return dev_err_probe(dev, ret, "rproc_add failed\n"); 216 216 217 217 return 0; 218 - } 219 - 220 - static void wkup_m3_rproc_remove(struct platform_device *pdev) 221 - { 222 - struct rproc *rproc = platform_get_drvdata(pdev); 223 - 224 - rproc_del(rproc); 225 218 } 226 219 227 220 #ifdef CONFIG_PM ··· 235 242 236 243 static struct platform_driver wkup_m3_rproc_driver = { 237 244 .probe = wkup_m3_rproc_probe, 238 - .remove = wkup_m3_rproc_remove, 239 245 .driver = { 240 246 .name = "wkup_m3_rproc", 241 247 .of_match_table = wkup_m3_rproc_of_match,