Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

uml: style fixes in the random driver

Give random.c a style workover while I'm changing it.

Signed-off-by: Jeff Dike <jdike@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Jeff Dike and committed by
Linus Torvalds
3d88958e 5d33e4d7

+40 -37
+40 -37
arch/um/drivers/random.c
··· 1 - /* Copyright (C) 2005 Jeff Dike <jdike@addtoit.com> */ 1 + /* Copyright (C) 2005 - 2008 Jeff Dike <jdike@{linux.intel,addtoit}.com> */ 2 + 2 3 /* Much of this ripped from drivers/char/hw_random.c, see there for other 3 4 * copyright. 4 5 * ··· 36 35 /* enforce read-only access to this chrdev */ 37 36 if ((filp->f_mode & FMODE_READ) == 0) 38 37 return -EINVAL; 39 - if (filp->f_mode & FMODE_WRITE) 38 + if ((filp->f_mode & FMODE_WRITE) != 0) 40 39 return -EINVAL; 41 40 42 41 return 0; ··· 45 44 static atomic_t host_sleep_count = ATOMIC_INIT(0); 46 45 47 46 static ssize_t rng_dev_read (struct file *filp, char __user *buf, size_t size, 48 - loff_t * offp) 47 + loff_t *offp) 49 48 { 50 - u32 data; 51 - int n, ret = 0, have_data; 49 + u32 data; 50 + int n, ret = 0, have_data; 52 51 53 - while(size){ 54 - n = os_read_file(random_fd, &data, sizeof(data)); 55 - if(n > 0){ 56 - have_data = n; 57 - while (have_data && size) { 58 - if (put_user((u8)data, buf++)) { 59 - ret = ret ? : -EFAULT; 60 - break; 61 - } 62 - size--; 63 - ret++; 64 - have_data--; 65 - data>>=8; 66 - } 67 - } 68 - else if(n == -EAGAIN){ 52 + while (size) { 53 + n = os_read_file(random_fd, &data, sizeof(data)); 54 + if (n > 0) { 55 + have_data = n; 56 + while (have_data && size) { 57 + if (put_user((u8) data, buf++)) { 58 + ret = ret ? : -EFAULT; 59 + break; 60 + } 61 + size--; 62 + ret++; 63 + have_data--; 64 + data >>= 8; 65 + } 66 + } 67 + else if (n == -EAGAIN) { 69 68 DECLARE_WAITQUEUE(wait, current); 70 69 71 - if (filp->f_flags & O_NONBLOCK) 72 - return ret ? : -EAGAIN; 70 + if (filp->f_flags & O_NONBLOCK) 71 + return ret ? : -EAGAIN; 73 72 74 73 atomic_inc(&host_sleep_count); 75 74 reactivate_fd(random_fd, RANDOM_IRQ); ··· 86 85 ignore_sigio_fd(random_fd); 87 86 deactivate_fd(random_fd, RANDOM_IRQ); 88 87 } 89 - } 90 - else return n; 88 + } 89 + else 90 + return n; 91 + 91 92 if (signal_pending (current)) 92 93 return ret ? : -ERESTARTSYS; 93 94 } ··· 123 120 { 124 121 int err; 125 122 126 - err = os_open_file("/dev/random", of_read(OPENFLAGS()), 0); 127 - if(err < 0) 128 - goto out; 123 + err = os_open_file("/dev/random", of_read(OPENFLAGS()), 0); 124 + if (err < 0) 125 + goto out; 129 126 130 - random_fd = err; 127 + random_fd = err; 131 128 132 129 err = um_request_irq(RANDOM_IRQ, random_fd, IRQ_READ, random_interrupt, 133 130 IRQF_DISABLED | IRQF_SAMPLE_RANDOM, "random", 134 131 NULL); 135 - if(err) 132 + if (err) 136 133 goto err_out_cleanup_hw; 137 134 138 135 sigio_broken(random_fd, 1); 139 136 140 137 err = misc_register (&rng_miscdev); 141 138 if (err) { 142 - printk (KERN_ERR RNG_MODULE_NAME ": misc device register failed\n"); 139 + printk (KERN_ERR RNG_MODULE_NAME ": misc device register " 140 + "failed\n"); 143 141 goto err_out_cleanup_hw; 144 142 } 143 + out: 144 + return err; 145 145 146 - out: 147 - return err; 148 - 149 - err_out_cleanup_hw: 146 + err_out_cleanup_hw: 150 147 os_close_file(random_fd); 151 - random_fd = -1; 152 - goto out; 148 + random_fd = -1; 149 + goto out; 153 150 } 154 151 155 152 /*