gro: fix different skb headrooms

Packets entering GRO might have different headrooms, even for a given
flow (because of implementation details in drivers, like copybreak).
We cant force drivers to deliver packets with a fixed headroom.

1) fix skb_segment()

skb_segment() makes the false assumption headrooms of fragments are same
than the head. When CHECKSUM_PARTIAL is used, this can give csum_start
errors, and crash later in skb_copy_and_csum_dev()

2) allocate a minimal skb for head of frag_list

skb_gro_receive() uses netdev_alloc_skb(headroom + skb_gro_offset(p)) to
allocate a fresh skb. This adds NET_SKB_PAD to a padding already
provided by netdevice, depending on various things, like copybreak.

Use alloc_skb() to allocate an exact padding, to reduce cache line
needs:
NET_SKB_PAD + NET_IP_ALIGN

bugzilla : https://bugzilla.kernel.org/show_bug.cgi?id=16626

Many thanks to Plamen Petrov, testing many debugging patches !
With help of Jarek Poplawski.

Reported-by: Plamen Petrov <pvp-lsts@fs.uni-ruse.bg>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
CC: Jarek Poplawski <jarkao2@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by Eric Dumazet and committed by David S. Miller 3d3be433 87f94b4e

+6 -2
+6 -2
net/core/skbuff.c
··· 2573 2573 __copy_skb_header(nskb, skb); 2574 2574 nskb->mac_len = skb->mac_len; 2575 2575 2576 + /* nskb and skb might have different headroom */ 2577 + if (nskb->ip_summed == CHECKSUM_PARTIAL) 2578 + nskb->csum_start += skb_headroom(nskb) - headroom; 2579 + 2576 2580 skb_reset_mac_header(nskb); 2577 2581 skb_set_network_header(nskb, skb->mac_len); 2578 2582 nskb->transport_header = (nskb->network_header + ··· 2706 2702 } else if (skb_gro_len(p) != pinfo->gso_size) 2707 2703 return -E2BIG; 2708 2704 2709 - headroom = skb_headroom(p); 2710 - nskb = netdev_alloc_skb(p->dev, headroom + skb_gro_offset(p)); 2705 + headroom = NET_SKB_PAD + NET_IP_ALIGN; 2706 + nskb = alloc_skb(headroom + skb_gro_offset(p), GFP_ATOMIC); 2711 2707 if (unlikely(!nskb)) 2712 2708 return -ENOMEM; 2713 2709