Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

HID: appleir: force input to be set

Some weird remotes are not correctly creating the input device. Their
report descriptor starts with:
0x06, 0x00, 0xff, // Usage Page (Vendor Defined Page 1) 0
0xa1, 0x01, // Collection (Application) 3

whereas others (which are correctly handled) start with:
0x05, 0x0c, // Usage Page (Consumer Devices) 0
0x09, 0x01, // Usage (Consumer Control) 2
0xa1, 0x01, // Collection (Application) 4

The rest of the report descriptor is the same.

Adding the quirk HID_QUIRK_HIDINPUT_FORCE forces hid-input to allocate
the inputs, and everything should be ok.

Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: James Henstridge <james.henstridge@canonical.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

authored by

Benjamin Tissoires and committed by
Jiri Kosina
3d18bd41 9316e580

+3
+3
drivers/hid/hid-appleir.c
··· 297 297 298 298 appleir->hid = hid; 299 299 300 + /* force input as some remotes bypass the input registration */ 301 + hid->quirks |= HID_QUIRK_HIDINPUT_FORCE; 302 + 300 303 spin_lock_init(&appleir->lock); 301 304 setup_timer(&appleir->key_up_timer, 302 305 key_up_tick, (unsigned long) appleir);