Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm: remove allow_fb_modifiers

The allow_fb_modifiers flag is unnecessary since it has been replaced
with fb_modifiers_not_supported flag.

v3:
- change the order as follows:
1. add fb_modifiers_not_supported flag
2. add default modifiers
3. remove allow_fb_modifiers flag

v5:
- keep a sanity check in plane init func

Signed-off-by: Tomohito Esaki <etom@igel.co.jp>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20220128060836.11216-4-etom@igel.co.jp

authored by

Tomohito Esaki and committed by
Daniel Vetter
3d082157 8be57683

-17
-1
drivers/gpu/drm/selftests/test-drm_framebuffer.c
··· 323 323 .max_width = MAX_WIDTH, 324 324 .min_height = MIN_HEIGHT, 325 325 .max_height = MAX_HEIGHT, 326 - .allow_fb_modifiers = true, 327 326 .funcs = &mock_config_funcs, 328 327 }, 329 328 };
-16
include/drm/drm_mode_config.h
··· 918 918 bool async_page_flip; 919 919 920 920 /** 921 - * @allow_fb_modifiers: 922 - * 923 - * Whether the driver supports fb modifiers in the ADDFB2.1 ioctl call. 924 - * Note that drivers should not set this directly, it is automatically 925 - * set in drm_universal_plane_init(). 926 - * 927 - * IMPORTANT: 928 - * 929 - * If this is set the driver must fill out the full implicit modifier 930 - * information in their &drm_mode_config_funcs.fb_create hook for legacy 931 - * userspace which does not set modifiers. Otherwise the GETFB2 ioctl is 932 - * broken for modifier aware userspace. 933 - */ 934 - bool allow_fb_modifiers; 935 - 936 - /** 937 921 * @fb_modifiers_not_supported: 938 922 * 939 923 * When this flag is set, the DRM device will not expose modifier