Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

perf ui browser hists: Provide feedback on unhandled hotkeys

Don't just eat unknown keys without providing visual feedback and
instructions on how to see which ones are assigned.

Suggested-by: Ingo Molnar <mingo@kernel.org>
Tested-by: Ingo Molnar <mingo@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: James Clark <james.clark@linaro.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/Z_TYux5fUg2pW-pF@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

+8 -2
+8 -2
tools/perf/ui/browsers/hists.c
··· 3308 3308 /* Fall thru */ 3309 3309 default: 3310 3310 helpline = "Press '?' for help on key bindings"; 3311 + ui_browser__warn_unhandled_hotkey(&browser->b, key, delay_secs, 3312 + ", use 'h'/'?'/F1 to see actions"); 3311 3313 continue; 3312 3314 } 3313 3315 ··· 3570 3568 case CTRL('c'): 3571 3569 goto out; 3572 3570 default: 3571 + ui_browser__warn_unhandled_hotkey(&menu->b, key, delay_secs, NULL); 3573 3572 continue; 3574 3573 } 3575 3574 } ··· 3696 3693 struct popup_action action; 3697 3694 char *br_cntr_text = NULL; 3698 3695 static const char help[] = 3699 - " q Quit \n" 3696 + " q/ESC Quit \n" 3700 3697 " B Branch counter abbr list (Optional)\n"; 3701 3698 3702 3699 browser = hist_browser__new(hists); ··· 3723 3720 3724 3721 switch (key) { 3725 3722 case 'q': 3723 + case K_ESC: 3726 3724 goto out; 3727 3725 case '?': 3728 3726 ui_browser__help_window(&browser->b, help); ··· 3750 3746 } 3751 3747 continue; 3752 3748 default: 3753 - break; 3749 + ui_browser__warn_unhandled_hotkey(&browser->b, key, 0, 3750 + ", use '?' to see actions"); 3751 + continue; 3754 3752 } 3755 3753 } 3756 3754