Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

scsi: target: Remove unused declarations

Commit 13247018d68f ("scsi: target: iscsi: Fix hang in the iSCSI login
code") removed iscsi_handle_login_thread_timeout() but left declaration.

Commit 3e1c81a95f0d ("iscsi-target: Refactor RX PDU logic + export request
PDU handling") left iscsi_target_get_initial_payload() declaration.

Commit d703ce2f7f4d ("iscsi/iser-target: Convert to command priv_size
usage") remove iscsit_alloc_cmd() but left declaration.

And finally, a few other declarations were never implenmented since
introduction in commit e48354ce078c ("iscsi-target: Add iSCSI fabric
support for target v4.1").

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
Link: https://lore.kernel.org/r/20240810093437.2586476-1-yuehaibing@huawei.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Yue Haibing and committed by
Martin K. Petersen
3c9265ed 2e4b02fa

-15
-2
drivers/target/iscsi/iscsi_target.h
··· 15 15 struct sockaddr_storage; 16 16 17 17 extern struct iscsi_tiqn *iscsit_get_tiqn_for_login(unsigned char *); 18 - extern struct iscsi_tiqn *iscsit_get_tiqn(unsigned char *, int); 19 18 extern void iscsit_put_tiqn_for_login(struct iscsi_tiqn *); 20 19 extern struct iscsi_tiqn *iscsit_add_tiqn(unsigned char *); 21 20 extern void iscsit_del_tiqn(struct iscsi_tiqn *); ··· 34 35 extern int iscsit_logout_closesession(struct iscsit_cmd *, struct iscsit_conn *); 35 36 extern int iscsit_logout_closeconnection(struct iscsit_cmd *, struct iscsit_conn *); 36 37 extern int iscsit_logout_removeconnforrecovery(struct iscsit_cmd *, struct iscsit_conn *); 37 - extern int iscsit_send_async_msg(struct iscsit_conn *, u16, u8, u8); 38 38 extern int iscsit_build_r2ts_for_cmd(struct iscsit_conn *, struct iscsit_cmd *, bool recovery); 39 39 extern void iscsit_thread_get_cpumask(struct iscsit_conn *); 40 40 extern int iscsi_target_tx_thread(void *);
-1
drivers/target/iscsi/iscsi_target_login.h
··· 24 24 extern void iscsi_post_login_handler(struct iscsi_np *, struct iscsit_conn *, u8); 25 25 extern void iscsi_target_login_sess_out(struct iscsit_conn *, bool, bool); 26 26 extern int iscsi_target_login_thread(void *); 27 - extern void iscsi_handle_login_thread_timeout(struct timer_list *t); 28 27 29 28 #endif /*** ISCSI_TARGET_LOGIN_H ***/
-2
drivers/target/iscsi/iscsi_target_nego.h
··· 15 15 unsigned char *); 16 16 extern int iscsi_target_check_login_request(struct iscsit_conn *, 17 17 struct iscsi_login *); 18 - extern int iscsi_target_get_initial_payload(struct iscsit_conn *, 19 - struct iscsi_login *); 20 18 extern int iscsi_target_locate_portal(struct iscsi_np *, struct iscsit_conn *, 21 19 struct iscsi_login *); 22 20 extern int iscsi_target_start_negotiation(
-5
drivers/target/iscsi/iscsi_target_tpg.h
··· 24 24 int); 25 25 extern int iscsit_tpg_enable_portal_group(struct iscsi_portal_group *); 26 26 extern int iscsit_tpg_disable_portal_group(struct iscsi_portal_group *, int); 27 - extern struct iscsi_node_acl *iscsit_tpg_add_initiator_node_acl( 28 - struct iscsi_portal_group *, const char *, u32); 29 - extern void iscsit_tpg_del_initiator_node_acl(struct iscsi_portal_group *, 30 - struct se_node_acl *); 31 27 extern struct iscsi_node_attrib *iscsit_tpg_get_node_attrib(struct iscsit_session *); 32 - extern void iscsit_tpg_del_external_nps(struct iscsi_tpg_np *); 33 28 extern struct iscsi_tpg_np *iscsit_tpg_locate_child_np(struct iscsi_tpg_np *, int); 34 29 extern struct iscsi_tpg_np *iscsit_tpg_add_network_portal(struct iscsi_portal_group *, 35 30 struct sockaddr_storage *, struct iscsi_tpg_np *,
-5
drivers/target/iscsi/iscsi_target_util.h
··· 17 17 extern struct iscsi_r2t *iscsit_get_r2t_from_list(struct iscsit_cmd *); 18 18 extern void iscsit_free_r2t(struct iscsi_r2t *, struct iscsit_cmd *); 19 19 extern void iscsit_free_r2ts_from_list(struct iscsit_cmd *); 20 - extern struct iscsit_cmd *iscsit_alloc_cmd(struct iscsit_conn *, gfp_t); 21 20 extern struct iscsit_cmd *iscsit_allocate_cmd(struct iscsit_conn *, int); 22 21 extern struct iscsi_seq *iscsit_get_seq_holder_for_datain(struct iscsit_cmd *, u32); 23 22 extern struct iscsi_seq *iscsit_get_seq_holder_for_r2t(struct iscsit_cmd *); ··· 33 34 extern struct iscsi_queue_req *iscsit_get_cmd_from_immediate_queue(struct iscsit_conn *); 34 35 extern int iscsit_add_cmd_to_response_queue(struct iscsit_cmd *, struct iscsit_conn *, u8); 35 36 extern struct iscsi_queue_req *iscsit_get_cmd_from_response_queue(struct iscsit_conn *); 36 - extern void iscsit_remove_cmd_from_tx_queues(struct iscsit_cmd *, struct iscsit_conn *); 37 37 extern bool iscsit_conn_all_queues_empty(struct iscsit_conn *); 38 38 extern void iscsit_free_queue_reqs_for_conn(struct iscsit_conn *); 39 39 extern void iscsit_release_cmd(struct iscsit_cmd *); ··· 62 64 extern int iscsit_fe_sendpage_sg(struct iscsit_cmd *, struct iscsit_conn *); 63 65 extern int iscsit_tx_login_rsp(struct iscsit_conn *, u8, u8); 64 66 extern void iscsit_print_session_params(struct iscsit_session *); 65 - extern int iscsit_print_dev_to_proc(char *, char **, off_t, int); 66 - extern int iscsit_print_sessions_to_proc(char *, char **, off_t, int); 67 - extern int iscsit_print_tpg_to_proc(char *, char **, off_t, int); 68 67 extern int rx_data(struct iscsit_conn *, struct kvec *, int, int); 69 68 extern int tx_data(struct iscsit_conn *, struct kvec *, int, int); 70 69 extern void iscsit_collect_login_stats(struct iscsit_conn *, u8, u8);