tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

drm/panel: nt35521: Break some CMDS into helper functions

Break select page cmds into helper functions.

Signed-off-by: Cong Yang <yangcong5@huaqin.corp-partner.google.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20240710084715.1119935-3-yangcong5@huaqin.corp-partner.google.com
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240710084715.1119935-3-yangcong5@huaqin.corp-partner.google.com

authored by

Cong Yang and committed by
Neil Armstrong 3c8d2d5d 93183c99

+21 -8
+21 -8
drivers/gpu/drm/panel/panel-sony-tulip-truly-nt35521.c
··· 25 25 struct gpio_desc *blen_gpio; 26 26 }; 27 27 28 + #define NT35521_DCS_SWITCH_PAGE 0xf0 29 + 30 + #define nt35521_switch_page(dsi_ctx, page) \ 31 + mipi_dsi_dcs_write_seq_multi(dsi_ctx, NT35521_DCS_SWITCH_PAGE, \ 32 + 0x55, 0xaa, 0x52, 0x08, (page)) 33 + 28 34 static inline 29 35 struct truly_nt35521 *to_truly_nt35521(struct drm_panel *panel) 30 36 { ··· 54 48 55 49 dsi->mode_flags |= MIPI_DSI_MODE_LPM; 56 50 57 - mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x00); 51 + nt35521_switch_page(&dsi_ctx, 0x00); 58 52 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xff, 0xaa, 0x55, 0xa5, 0x80); 59 53 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0x6f, 0x11, 0x00); 60 54 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xf7, 0x20, 0x00); ··· 65 59 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xbb, 0x11, 0x11); 66 60 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xbc, 0x00, 0x00); 67 61 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xb6, 0x02); 68 - mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x01); 62 + 63 + nt35521_switch_page(&dsi_ctx, 0x01); 69 64 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xb0, 0x09, 0x09); 70 65 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xb1, 0x09, 0x09); 71 66 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xbc, 0x8c, 0x00); ··· 78 71 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xb4, 0x25, 0x25); 79 72 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xb9, 0x43, 0x43); 80 73 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xba, 0x24, 0x24); 81 - mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x02); 74 + 75 + nt35521_switch_page(&dsi_ctx, 0x02); 82 76 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xee, 0x03); 83 77 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xb0, 84 78 0x00, 0xb2, 0x00, 0xb3, 0x00, 0xb6, 0x00, 0xc3, ··· 111 103 0x02, 0x93, 0x02, 0xcd, 0x02, 0xf6, 0x03, 0x31, 112 104 0x03, 0x6c, 0x03, 0xe9, 0x03, 0xef, 0x03, 0xf4); 113 105 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xbb, 0x03, 0xf6, 0x03, 0xf7); 114 - mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x03); 106 + 107 + nt35521_switch_page(&dsi_ctx, 0x03); 115 108 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xb0, 0x22, 0x00); 116 109 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xb1, 0x22, 0x00); 117 110 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xb2, 0x05, 0x00, 0x60, 0x00, 0x00); ··· 131 122 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xc5, 0xc0); 132 123 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xc6, 0x00); 133 124 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xc7, 0x00); 134 - mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x05); 125 + 126 + nt35521_switch_page(&dsi_ctx, 0x05); 135 127 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xb0, 0x17, 0x06); 136 128 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xb1, 0x17, 0x06); 137 129 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xb2, 0x17, 0x06); ··· 188 178 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xeb, 0x00); 189 179 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xec, 0x00); 190 180 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xed, 0x30); 191 - mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x06); 181 + 182 + nt35521_switch_page(&dsi_ctx, 0x06); 192 183 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xb0, 0x31, 0x31); 193 184 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xb1, 0x31, 0x31); 194 185 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xb2, 0x2d, 0x2e); ··· 246 235 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0x6f, 0x11); 247 236 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xf3, 0x01); 248 237 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0x35, 0x00); 249 - mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x00); 238 + 239 + nt35521_switch_page(&dsi_ctx, 0x00); 250 240 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xd9, 0x02, 0x03, 0x00); 251 241 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xf0, 0x55, 0xaa, 0x52, 0x00, 0x00); 252 - mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x00); 242 + 243 + nt35521_switch_page(&dsi_ctx, 0x00); 253 244 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xb1, 0x6c, 0x21); 254 245 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xf0, 0x55, 0xaa, 0x52, 0x00, 0x00); 255 246 mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0x35, 0x00);