Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ACPI: PM: Remove redundant cache flushing

ACPICA code takes care about cache flushing on S1/S2/S3 in
acpi_hw_extended_sleep() and acpi_hw_legacy_sleep().

acpi_suspend_enter() calls into ACPICA code via acpi_enter_sleep_state()
for S1 or x86_acpi_suspend_lowlevel() for S3.

acpi_sleep_prepare() call tree:
__acpi_pm_prepare()
acpi_pm_prepare()
acpi_suspend_ops::prepare_late()
acpi_hibernation_ops::pre_snapshot()
acpi_hibernation_ops::prepare()
acpi_suspend_begin_old()
acpi_suspend_begin_old::begin()
acpi_hibernation_begin_old()
acpi_hibernation_ops_old::acpi_hibernation_begin_old()
acpi_power_off_prepare()
pm_power_off_prepare()

Hibernation (S4) and Power Off (S5) don't require cache flushing, so
the only interesting callsites are acpi_suspend_ops::prepare_late()
and acpi_suspend_begin_old::begin(). Both of them have cache flush
on ->enter() operation in acpi_suspend_enter().

Remove redundant ACPI_FLUSH_CPU_CACHE() in acpi_sleep_prepare() and
acpi_suspend_enter().

Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

authored by

Kirill A. Shutemov and committed by
Rafael J. Wysocki
3c89857a 53d01e20

-3
-3
drivers/acpi/sleep.c
··· 73 73 acpi_set_waking_vector(acpi_wakeup_address); 74 74 75 75 } 76 - ACPI_FLUSH_CPU_CACHE(); 77 76 #endif 78 77 pr_info("Preparing to enter system sleep state S%d\n", acpi_state); 79 78 acpi_enable_wakeup_devices(acpi_state); ··· 564 565 acpi_status status = AE_OK; 565 566 u32 acpi_state = acpi_target_sleep_state; 566 567 int error; 567 - 568 - ACPI_FLUSH_CPU_CACHE(); 569 568 570 569 trace_suspend_resume(TPS("acpi_suspend"), acpi_state, true); 571 570 switch (acpi_state) {