Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

genirq: Don't suspend nested_thread irqs over system suspend

Nested IRQs can only fire when the parent irq fires. So when the
parent is suspended, there is no need to suspend the child irq.

Suspending nested irqs can cause a problem is they are suspended or
resumed in the wrong order. If an interrupt fires while the parent is
active but the child is suspended, then the interrupt will not be
acknowledged properly and so an interrupt storm can result. This is
particularly likely if the parent is resumed before the child, and the
interrupt was raised during suspend.

Ensuring correct ordering would be possible, but it is simpler to just
never suspend nested interrupts.

Signed-off-by: NeilBrown <neil@brown.name>
Cc: GTA04 owners <gta04-owner@goldelico.com>
Cc: Kalle Jokiniemi <kalle.jokiniemi@jollamobile.com>
Acked-by: Peter Zijlstra <peterz@infradead.org>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Link: http://lkml.kernel.org/r/20150517151934.2393e8f8@notabene.brown
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

authored by

NeilBrown and committed by
Thomas Gleixner
3c646f2c 63781394

+4
+4
kernel/irq/pm.c
··· 123 123 unsigned long flags; 124 124 bool sync; 125 125 126 + if (irq_settings_is_nested_thread(desc)) 127 + continue; 126 128 raw_spin_lock_irqsave(&desc->lock, flags); 127 129 sync = suspend_device_irq(desc, irq); 128 130 raw_spin_unlock_irqrestore(&desc->lock, flags); ··· 164 162 desc->action->flags & IRQF_EARLY_RESUME; 165 163 166 164 if (!is_early && want_early) 165 + continue; 166 + if (irq_settings_is_nested_thread(desc)) 167 167 continue; 168 168 169 169 raw_spin_lock_irqsave(&desc->lock, flags);