Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ps3vram: add error handling support for add_disk()

We never checked for errors on add_disk() as this function
returned void. Now that this is fixed, use the shiny new
error handling.

Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Acked-by: Geoff Levand <geoff@infradead.org>
Link: https://lore.kernel.org/r/20211015235219.2191207-12-mcgrof@kernel.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>

authored by

Luis Chamberlain and committed by
Jens Axboe
3c30883a ff4cbe0f

+6 -1
+6 -1
drivers/block/ps3vram.c
··· 753 753 dev_info(&dev->core, "%s: Using %llu MiB of GPU memory\n", 754 754 gendisk->disk_name, get_capacity(gendisk) >> 11); 755 755 756 - device_add_disk(&dev->core, gendisk, NULL); 756 + error = device_add_disk(&dev->core, gendisk, NULL); 757 + if (error) 758 + goto out_cleanup_disk; 759 + 757 760 return 0; 758 761 762 + out_cleanup_disk: 763 + blk_cleanup_disk(gendisk); 759 764 out_cache_cleanup: 760 765 remove_proc_entry(DEVICE_NAME, NULL); 761 766 ps3vram_cache_cleanup(dev);