Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drivers: gpio: bt8xx: prefer dev_err()/dev_warn() over of raw printk

For logging in device contexts, dev_*() functions are preferred over
raw printk(), which also print out device name.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
Link: https://lore.kernel.org/r/20201203182423.5499-1-info@metux.net
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

authored by

Enrico Weigelt, metux IT consult and committed by
Linus Walleij
3bf1d26c dd0fa811

+4 -4
+4 -4
drivers/gpio/gpio-bt8xx.c
··· 175 175 176 176 err = pci_enable_device(dev); 177 177 if (err) { 178 - printk(KERN_ERR "bt8xxgpio: Can't enable device.\n"); 178 + dev_err(&dev->dev, "can't enable device.\n"); 179 179 return err; 180 180 } 181 181 if (!devm_request_mem_region(&dev->dev, pci_resource_start(dev, 0), 182 182 pci_resource_len(dev, 0), 183 183 "bt8xxgpio")) { 184 - printk(KERN_WARNING "bt8xxgpio: Can't request iomem (0x%llx).\n", 184 + dev_warn(&dev->dev, "can't request iomem (0x%llx).\n", 185 185 (unsigned long long)pci_resource_start(dev, 0)); 186 186 err = -EBUSY; 187 187 goto err_disable; ··· 191 191 192 192 bg->mmio = devm_ioremap(&dev->dev, pci_resource_start(dev, 0), 0x1000); 193 193 if (!bg->mmio) { 194 - printk(KERN_ERR "bt8xxgpio: ioremap() failed\n"); 194 + dev_err(&dev->dev, "ioremap() failed\n"); 195 195 err = -EIO; 196 196 goto err_disable; 197 197 } ··· 207 207 bt8xxgpio_gpio_setup(bg); 208 208 err = gpiochip_add_data(&bg->gpio, bg); 209 209 if (err) { 210 - printk(KERN_ERR "bt8xxgpio: Failed to register GPIOs\n"); 210 + dev_err(&dev->dev, "failed to register GPIOs\n"); 211 211 goto err_disable; 212 212 } 213 213