Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

backlight: hp680_bl - Use platform_device_register_simple()

Use platform_device_register_simple() and also fix error
handling when platform_device_alloc() fails (hp680_bl_driver
is left registered).

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Richard Purdie <rpurdie@linux.intel.com>

authored by

Akinobu Mita and committed by
Richard Purdie
3bcdcc0e 9e42d0cf

+8 -12
+8 -12
drivers/video/backlight/hp680_bl.c
··· 151 151 int ret; 152 152 153 153 ret = platform_driver_register(&hp680bl_driver); 154 - if (!ret) { 155 - hp680bl_device = platform_device_alloc("hp680-bl", -1); 156 - if (!hp680bl_device) 157 - return -ENOMEM; 158 - 159 - ret = platform_device_add(hp680bl_device); 160 - 161 - if (ret) { 162 - platform_device_put(hp680bl_device); 163 - platform_driver_unregister(&hp680bl_driver); 164 - } 154 + if (ret) 155 + return ret; 156 + hp680bl_device = platform_device_register_simple("hp680-bl", -1, 157 + NULL, 0); 158 + if (IS_ERR(hp680bl_device)) { 159 + platform_driver_unregister(&hp680bl_driver); 160 + return PTR_ERR(hp680bl_device); 165 161 } 166 - return ret; 162 + return 0; 167 163 } 168 164 169 165 static void __exit hp680bl_exit(void)