Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

scsi: ufs: Constify the third pwr_change_notify() argument

The third pwr_change_notify() argument is an input parameter. Make this
explicit by declaring it 'const'.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20250212213838.1044917-1-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Bart Van Assche and committed by
Martin K. Petersen
3bcd901e 0ea163a1

+26 -26
+3 -3
drivers/ufs/core/ufshcd-priv.h
··· 159 159 } 160 160 161 161 static inline int ufshcd_vops_pwr_change_notify(struct ufs_hba *hba, 162 - enum ufs_notify_change_status status, 163 - struct ufs_pa_layer_attr *dev_max_params, 164 - struct ufs_pa_layer_attr *dev_req_params) 162 + enum ufs_notify_change_status status, 163 + const struct ufs_pa_layer_attr *dev_max_params, 164 + struct ufs_pa_layer_attr *dev_req_params) 165 165 { 166 166 if (hba->vops && hba->vops->pwr_change_notify) 167 167 return hba->vops->pwr_change_notify(hba, status,
+5 -5
drivers/ufs/host/ufs-exynos.c
··· 321 321 } 322 322 323 323 static int exynosauto_ufs_post_pwr_change(struct exynos_ufs *ufs, 324 - struct ufs_pa_layer_attr *pwr) 324 + const struct ufs_pa_layer_attr *pwr) 325 325 { 326 326 struct ufs_hba *hba = ufs->hba; 327 327 u32 enabled_vh; ··· 396 396 } 397 397 398 398 static int exynos7_ufs_post_pwr_change(struct exynos_ufs *ufs, 399 - struct ufs_pa_layer_attr *pwr) 399 + const struct ufs_pa_layer_attr *pwr) 400 400 { 401 401 struct ufs_hba *hba = ufs->hba; 402 402 int lanes = max_t(u32, pwr->lane_rx, pwr->lane_tx); ··· 813 813 } 814 814 815 815 static int exynos_ufs_pre_pwr_mode(struct ufs_hba *hba, 816 - struct ufs_pa_layer_attr *dev_max_params, 816 + const struct ufs_pa_layer_attr *dev_max_params, 817 817 struct ufs_pa_layer_attr *dev_req_params) 818 818 { 819 819 struct exynos_ufs *ufs = ufshcd_get_variant(hba); ··· 865 865 866 866 #define PWR_MODE_STR_LEN 64 867 867 static int exynos_ufs_post_pwr_mode(struct ufs_hba *hba, 868 - struct ufs_pa_layer_attr *pwr_req) 868 + const struct ufs_pa_layer_attr *pwr_req) 869 869 { 870 870 struct exynos_ufs *ufs = ufshcd_get_variant(hba); 871 871 struct phy *generic_phy = ufs->phy; ··· 1634 1634 1635 1635 static int exynos_ufs_pwr_change_notify(struct ufs_hba *hba, 1636 1636 enum ufs_notify_change_status status, 1637 - struct ufs_pa_layer_attr *dev_max_params, 1637 + const struct ufs_pa_layer_attr *dev_max_params, 1638 1638 struct ufs_pa_layer_attr *dev_req_params) 1639 1639 { 1640 1640 int ret = 0;
+1 -1
drivers/ufs/host/ufs-exynos.h
··· 188 188 int (*pre_pwr_change)(struct exynos_ufs *ufs, 189 189 struct ufs_pa_layer_attr *pwr); 190 190 int (*post_pwr_change)(struct exynos_ufs *ufs, 191 - struct ufs_pa_layer_attr *pwr); 191 + const struct ufs_pa_layer_attr *pwr); 192 192 int (*pre_hce_enable)(struct exynos_ufs *ufs); 193 193 int (*post_hce_enable)(struct exynos_ufs *ufs); 194 194 };
+3 -3
drivers/ufs/host/ufs-hisi.c
··· 361 361 } 362 362 363 363 static int ufs_hisi_pwr_change_notify(struct ufs_hba *hba, 364 - enum ufs_notify_change_status status, 365 - struct ufs_pa_layer_attr *dev_max_params, 366 - struct ufs_pa_layer_attr *dev_req_params) 364 + enum ufs_notify_change_status status, 365 + const struct ufs_pa_layer_attr *dev_max_params, 366 + struct ufs_pa_layer_attr *dev_req_params) 367 367 { 368 368 struct ufs_host_params host_params; 369 369 int ret = 0;
+5 -5
drivers/ufs/host/ufs-mediatek.c
··· 1081 1081 } 1082 1082 1083 1083 static int ufs_mtk_pre_pwr_change(struct ufs_hba *hba, 1084 - struct ufs_pa_layer_attr *dev_max_params, 1085 - struct ufs_pa_layer_attr *dev_req_params) 1084 + const struct ufs_pa_layer_attr *dev_max_params, 1085 + struct ufs_pa_layer_attr *dev_req_params) 1086 1086 { 1087 1087 struct ufs_mtk_host *host = ufshcd_get_variant(hba); 1088 1088 struct ufs_host_params host_params; ··· 1134 1134 } 1135 1135 1136 1136 static int ufs_mtk_pwr_change_notify(struct ufs_hba *hba, 1137 - enum ufs_notify_change_status stage, 1138 - struct ufs_pa_layer_attr *dev_max_params, 1139 - struct ufs_pa_layer_attr *dev_req_params) 1137 + enum ufs_notify_change_status stage, 1138 + const struct ufs_pa_layer_attr *dev_max_params, 1139 + struct ufs_pa_layer_attr *dev_req_params) 1140 1140 { 1141 1141 int ret = 0; 1142 1142
+1 -1
drivers/ufs/host/ufs-qcom.c
··· 807 807 808 808 static int ufs_qcom_pwr_change_notify(struct ufs_hba *hba, 809 809 enum ufs_notify_change_status status, 810 - struct ufs_pa_layer_attr *dev_max_params, 810 + const struct ufs_pa_layer_attr *dev_max_params, 811 811 struct ufs_pa_layer_attr *dev_req_params) 812 812 { 813 813 struct ufs_qcom_host *host = ufshcd_get_variant(hba);
+3 -3
drivers/ufs/host/ufs-sprd.c
··· 160 160 } 161 161 162 162 static int sprd_ufs_pwr_change_notify(struct ufs_hba *hba, 163 - enum ufs_notify_change_status status, 164 - struct ufs_pa_layer_attr *dev_max_params, 165 - struct ufs_pa_layer_attr *dev_req_params) 163 + enum ufs_notify_change_status status, 164 + const struct ufs_pa_layer_attr *dev_max_params, 165 + struct ufs_pa_layer_attr *dev_req_params) 166 166 { 167 167 struct ufs_sprd_host *host = ufshcd_get_variant(hba); 168 168
+1 -1
drivers/ufs/host/ufshcd-pci.c
··· 157 157 158 158 static int ufs_intel_lkf_pwr_change_notify(struct ufs_hba *hba, 159 159 enum ufs_notify_change_status status, 160 - struct ufs_pa_layer_attr *dev_max_params, 160 + const struct ufs_pa_layer_attr *dev_max_params, 161 161 struct ufs_pa_layer_attr *dev_req_params) 162 162 { 163 163 int err = 0;
+4 -4
include/ufs/ufshcd.h
··· 353 353 int (*link_startup_notify)(struct ufs_hba *, 354 354 enum ufs_notify_change_status); 355 355 int (*pwr_change_notify)(struct ufs_hba *, 356 - enum ufs_notify_change_status status, 357 - struct ufs_pa_layer_attr *desired_pwr_mode, 358 - struct ufs_pa_layer_attr *final_params); 356 + enum ufs_notify_change_status status, 357 + const struct ufs_pa_layer_attr *desired_pwr_mode, 358 + struct ufs_pa_layer_attr *final_params); 359 359 void (*setup_xfer_req)(struct ufs_hba *hba, int tag, 360 360 bool is_scsi_cmd); 361 361 void (*setup_task_mgmt)(struct ufs_hba *, int, u8); ··· 1429 1429 return ufshcd_dme_get_attr(hba, attr_sel, mib_val, DME_PEER); 1430 1430 } 1431 1431 1432 - static inline bool ufshcd_is_hs_mode(struct ufs_pa_layer_attr *pwr_info) 1432 + static inline bool ufshcd_is_hs_mode(const struct ufs_pa_layer_attr *pwr_info) 1433 1433 { 1434 1434 return (pwr_info->pwr_rx == FAST_MODE || 1435 1435 pwr_info->pwr_rx == FASTAUTO_MODE) &&