Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

USB: ftdi_sio: checkpatch cleanups

Minor whitespace cleanups to make checkpatch happy.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

+87 -81
+1 -1
drivers/usb/serial/ftdi_sio.c
··· 61 61 62 62 struct ftdi_private { 63 63 struct kref kref; 64 - ftdi_chip_type_t chip_type; 64 + enum ftdi_chip_type chip_type; 65 65 /* type of device, either SIO or FT8U232AM */ 66 66 int baud_base; /* baud base clock for divisor setting */ 67 67 int custom_divisor; /* custom_divisor kludge, this is for
+65 -59
drivers/usb/serial/ftdi_sio.h
··· 23 23 */ 24 24 25 25 /* Commands */ 26 - #define FTDI_SIO_RESET 0 /* Reset the port */ 27 - #define FTDI_SIO_MODEM_CTRL 1 /* Set the modem control register */ 28 - #define FTDI_SIO_SET_FLOW_CTRL 2 /* Set flow control register */ 29 - #define FTDI_SIO_SET_BAUD_RATE 3 /* Set baud rate */ 30 - #define FTDI_SIO_SET_DATA 4 /* Set the data characteristics of the port */ 31 - #define FTDI_SIO_GET_MODEM_STATUS 5 /* Retrieve current value of modem status register */ 32 - #define FTDI_SIO_SET_EVENT_CHAR 6 /* Set the event character */ 33 - #define FTDI_SIO_SET_ERROR_CHAR 7 /* Set the error character */ 26 + #define FTDI_SIO_RESET 0 /* Reset the port */ 27 + #define FTDI_SIO_MODEM_CTRL 1 /* Set the modem control register */ 28 + #define FTDI_SIO_SET_FLOW_CTRL 2 /* Set flow control register */ 29 + #define FTDI_SIO_SET_BAUD_RATE 3 /* Set baud rate */ 30 + #define FTDI_SIO_SET_DATA 4 /* Set the data characteristics of 31 + the port */ 32 + #define FTDI_SIO_GET_MODEM_STATUS 5 /* Retrieve current value of modem 33 + status register */ 34 + #define FTDI_SIO_SET_EVENT_CHAR 6 /* Set the event character */ 35 + #define FTDI_SIO_SET_ERROR_CHAR 7 /* Set the error character */ 34 36 #define FTDI_SIO_SET_LATENCY_TIMER 9 /* Set the latency timer */ 35 37 #define FTDI_SIO_GET_LATENCY_TIMER 10 /* Get the latency timer */ 36 38 ··· 54 52 */ 55 53 56 54 /* Port Identifier Table */ 57 - #define PIT_DEFAULT 0 /* SIOA */ 55 + #define PIT_DEFAULT 0 /* SIOA */ 58 56 #define PIT_SIOA 1 /* SIOA */ 59 57 /* The device this driver is tested with one has only one port */ 60 58 #define PIT_SIOB 2 /* SIOB */ ··· 105 103 * wLength: 0 106 104 * Data: None 107 105 * The BaudDivisor values are calculated as follows: 108 - * - BaseClock is either 12000000 or 48000000 depending on the device. FIXME: I wish 109 - * I knew how to detect old chips to select proper base clock! 106 + * - BaseClock is either 12000000 or 48000000 depending on the device. 107 + * FIXME: I wish I knew how to detect old chips to select proper base clock! 110 108 * - BaudDivisor is a fixed point number encoded in a funny way. 111 109 * (--WRONG WAY OF THINKING--) 112 110 * BaudDivisor is a fixed point number encoded with following bit weighs: 113 111 * (-2)(-1)(13..0). It is a radical with a denominator of 4, so values 114 112 * end with 0.0 (00...), 0.25 (10...), 0.5 (01...), and 0.75 (11...). 115 113 * (--THE REALITY--) 116 - * The both-bits-set has quite different meaning from 0.75 - the chip designers 117 - * have decided it to mean 0.125 instead of 0.75. 114 + * The both-bits-set has quite different meaning from 0.75 - the chip 115 + * designers have decided it to mean 0.125 instead of 0.75. 118 116 * This info looked up in FTDI application note "FT8U232 DEVICES \ Data Rates 119 117 * and Flow Control Consideration for USB to RS232". 120 118 * - BaudDivisor = (BaseClock / 16) / BaudRate, where the (=) operation should 121 - * automagically re-encode the resulting value to take fractions into consideration. 119 + * automagically re-encode the resulting value to take fractions into 120 + * consideration. 122 121 * As all values are integers, some bit twiddling is in order: 123 122 * BaudDivisor = (BaseClock / 16 / BaudRate) | 124 123 * (((BaseClock / 2 / BaudRate) & 4) ? 0x4000 // 0.5 ··· 149 146 * not supported by the FT8U232AM). 150 147 */ 151 148 152 - typedef enum { 149 + enum ftdi_chip_type { 153 150 SIO = 1, 154 151 FT8U232AM = 2, 155 152 FT232BM = 3, ··· 157 154 FT232RL = 5, 158 155 FT2232H = 6, 159 156 FT4232H = 7 160 - } ftdi_chip_type_t; 157 + }; 161 158 162 - typedef enum { 163 - ftdi_sio_b300 = 0, 164 - ftdi_sio_b600 = 1, 165 - ftdi_sio_b1200 = 2, 166 - ftdi_sio_b2400 = 3, 167 - ftdi_sio_b4800 = 4, 168 - ftdi_sio_b9600 = 5, 169 - ftdi_sio_b19200 = 6, 170 - ftdi_sio_b38400 = 7, 171 - ftdi_sio_b57600 = 8, 172 - ftdi_sio_b115200 = 9 173 - } FTDI_SIO_baudrate_t; 159 + enum ftdi_sio_baudrate { 160 + ftdi_sio_b300 = 0, 161 + ftdi_sio_b600 = 1, 162 + ftdi_sio_b1200 = 2, 163 + ftdi_sio_b2400 = 3, 164 + ftdi_sio_b4800 = 4, 165 + ftdi_sio_b9600 = 5, 166 + ftdi_sio_b19200 = 6, 167 + ftdi_sio_b38400 = 7, 168 + ftdi_sio_b57600 = 8, 169 + ftdi_sio_b115200 = 9 170 + }; 174 171 175 172 /* 176 - * The ftdi_8U232AM_xxMHz_byyy constants have been removed. The encoded divisor values 177 - * are calculated internally. 173 + * The ftdi_8U232AM_xxMHz_byyy constants have been removed. The encoded divisor 174 + * values are calculated internally. 178 175 */ 179 - 180 - #define FTDI_SIO_SET_DATA_REQUEST FTDI_SIO_SET_DATA 181 - #define FTDI_SIO_SET_DATA_REQUEST_TYPE 0x40 182 - #define FTDI_SIO_SET_DATA_PARITY_NONE (0x0 << 8) 183 - #define FTDI_SIO_SET_DATA_PARITY_ODD (0x1 << 8) 184 - #define FTDI_SIO_SET_DATA_PARITY_EVEN (0x2 << 8) 185 - #define FTDI_SIO_SET_DATA_PARITY_MARK (0x3 << 8) 186 - #define FTDI_SIO_SET_DATA_PARITY_SPACE (0x4 << 8) 187 - #define FTDI_SIO_SET_DATA_STOP_BITS_1 (0x0 << 11) 188 - #define FTDI_SIO_SET_DATA_STOP_BITS_15 (0x1 << 11) 189 - #define FTDI_SIO_SET_DATA_STOP_BITS_2 (0x2 << 11) 190 - #define FTDI_SIO_SET_BREAK (0x1 << 14) 176 + #define FTDI_SIO_SET_DATA_REQUEST FTDI_SIO_SET_DATA 177 + #define FTDI_SIO_SET_DATA_REQUEST_TYPE 0x40 178 + #define FTDI_SIO_SET_DATA_PARITY_NONE (0x0 << 8) 179 + #define FTDI_SIO_SET_DATA_PARITY_ODD (0x1 << 8) 180 + #define FTDI_SIO_SET_DATA_PARITY_EVEN (0x2 << 8) 181 + #define FTDI_SIO_SET_DATA_PARITY_MARK (0x3 << 8) 182 + #define FTDI_SIO_SET_DATA_PARITY_SPACE (0x4 << 8) 183 + #define FTDI_SIO_SET_DATA_STOP_BITS_1 (0x0 << 11) 184 + #define FTDI_SIO_SET_DATA_STOP_BITS_15 (0x1 << 11) 185 + #define FTDI_SIO_SET_DATA_STOP_BITS_2 (0x2 << 11) 186 + #define FTDI_SIO_SET_BREAK (0x1 << 14) 191 187 /* FTDI_SIO_SET_DATA */ 192 188 193 189 /* ··· 289 287 * 290 288 * A value of zero in the hIndex field disables handshaking 291 289 * 292 - * If Xon/Xoff handshaking is specified, the hValue field should contain the XOFF character 293 - * and the lValue field contains the XON character. 290 + * If Xon/Xoff handshaking is specified, the hValue field should contain the 291 + * XOFF character and the lValue field contains the XON character. 294 292 */ 295 293 296 294 /* ··· 375 373 376 374 /* FTDI_SIO_SET_ERROR_CHAR */ 377 375 378 - /* Set the parity error replacement character for the specified communications port */ 376 + /* 377 + * Set the parity error replacement character for the specified communications 378 + * port 379 + */ 379 380 380 381 /* 381 382 * BmRequestType: 0100 0000b ··· 501 496 * 502 497 * IN Endpoint 503 498 * 504 - * The device reserves the first two bytes of data on this endpoint to contain the current 505 - * values of the modem and line status registers. In the absence of data, the device 506 - * generates a message consisting of these two status bytes every 40 ms 499 + * The device reserves the first two bytes of data on this endpoint to contain 500 + * the current values of the modem and line status registers. In the absence of 501 + * data, the device generates a message consisting of these two status bytes 502 + * every 40 ms 507 503 * 508 504 * Byte 0: Modem Status 509 505 * ··· 536 530 #define FTDI_RS0_RI (1 << 6) 537 531 #define FTDI_RS0_RLSD (1 << 7) 538 532 539 - #define FTDI_RS_DR 1 540 - #define FTDI_RS_OE (1<<1) 541 - #define FTDI_RS_PE (1<<2) 542 - #define FTDI_RS_FE (1<<3) 543 - #define FTDI_RS_BI (1<<4) 544 - #define FTDI_RS_THRE (1<<5) 545 - #define FTDI_RS_TEMT (1<<6) 546 - #define FTDI_RS_FIFO (1<<7) 533 + #define FTDI_RS_DR 1 534 + #define FTDI_RS_OE (1<<1) 535 + #define FTDI_RS_PE (1<<2) 536 + #define FTDI_RS_FE (1<<3) 537 + #define FTDI_RS_BI (1<<4) 538 + #define FTDI_RS_THRE (1<<5) 539 + #define FTDI_RS_TEMT (1<<6) 540 + #define FTDI_RS_FIFO (1<<7) 547 541 548 542 /* 549 543 * OUT Endpoint 550 544 * 551 - * This device reserves the first bytes of data on this endpoint contain the length 552 - * and port identifier of the message. For the FTDI USB Serial converter the port 553 - * identifier is always 1. 545 + * This device reserves the first bytes of data on this endpoint contain the 546 + * length and port identifier of the message. For the FTDI USB Serial converter 547 + * the port identifier is always 1. 554 548 * 555 549 * Byte 0: Line Status 556 550 *
+21 -21
drivers/usb/serial/ftdi_sio_ids.h
··· 275 275 /* 276 276 * Hameg HO820 and HO870 interface (using VID 0x0403) 277 277 */ 278 - #define HAMEG_HO820_PID 0xed74 279 - #define HAMEG_HO870_PID 0xed71 278 + #define HAMEG_HO820_PID 0xed74 279 + #define HAMEG_HO870_PID 0xed71 280 280 281 281 /* 282 282 * MaxStream devices www.maxstream.net ··· 289 289 * and Mike Studer (K6EEP) <k6eep@hamsoftware.org>. 290 290 * Ian Abbott <abbotti@mev.co.uk> added a few more from the driver INF file. 291 291 */ 292 - #define FTDI_MHAM_KW_PID 0xEEE8 /* USB-KW interface */ 293 - #define FTDI_MHAM_YS_PID 0xEEE9 /* USB-YS interface */ 294 - #define FTDI_MHAM_Y6_PID 0xEEEA /* USB-Y6 interface */ 295 - #define FTDI_MHAM_Y8_PID 0xEEEB /* USB-Y8 interface */ 296 - #define FTDI_MHAM_IC_PID 0xEEEC /* USB-IC interface */ 297 - #define FTDI_MHAM_DB9_PID 0xEEED /* USB-DB9 interface */ 298 - #define FTDI_MHAM_RS232_PID 0xEEEE /* USB-RS232 interface */ 299 - #define FTDI_MHAM_Y9_PID 0xEEEF /* USB-Y9 interface */ 292 + #define FTDI_MHAM_KW_PID 0xEEE8 /* USB-KW interface */ 293 + #define FTDI_MHAM_YS_PID 0xEEE9 /* USB-YS interface */ 294 + #define FTDI_MHAM_Y6_PID 0xEEEA /* USB-Y6 interface */ 295 + #define FTDI_MHAM_Y8_PID 0xEEEB /* USB-Y8 interface */ 296 + #define FTDI_MHAM_IC_PID 0xEEEC /* USB-IC interface */ 297 + #define FTDI_MHAM_DB9_PID 0xEEED /* USB-DB9 interface */ 298 + #define FTDI_MHAM_RS232_PID 0xEEEE /* USB-RS232 interface */ 299 + #define FTDI_MHAM_Y9_PID 0xEEEF /* USB-Y9 interface */ 300 300 301 301 /* Domintell products http://www.domintell.com */ 302 302 #define FTDI_DOMINTELL_DGQG_PID 0xEF50 /* Master */ ··· 483 483 * Blackfin gnICE JTAG 484 484 * http://docs.blackfin.uclinux.org/doku.php?id=hw:jtag:gnice 485 485 */ 486 - #define ADI_VID 0x0456 487 - #define ADI_GNICE_PID 0xF000 488 - #define ADI_GNICEPLUS_PID 0xF001 486 + #define ADI_VID 0x0456 487 + #define ADI_GNICE_PID 0xF000 488 + #define ADI_GNICEPLUS_PID 0xF001 489 489 490 490 /* 491 491 * RATOC REX-USB60F ··· 611 611 #define SEALEVEL_2802_7_PID 0X2872 /* SeaLINK+8/485 (2802) Port 7 */ 612 612 #define SEALEVEL_2802_8_PID 0X2882 /* SeaLINK+8/485 (2802) Port 8 */ 613 613 #define SEALEVEL_2803_1_PID 0X2813 /* SeaLINK+8 (2803) Port 1 */ 614 - #define SEALEVEL_2803_2_PID 0X2823 /* SeaLINK+8 (2803) Port 2 */ 615 - #define SEALEVEL_2803_3_PID 0X2833 /* SeaLINK+8 (2803) Port 3 */ 616 - #define SEALEVEL_2803_4_PID 0X2843 /* SeaLINK+8 (2803) Port 4 */ 617 - #define SEALEVEL_2803_5_PID 0X2853 /* SeaLINK+8 (2803) Port 5 */ 618 - #define SEALEVEL_2803_6_PID 0X2863 /* SeaLINK+8 (2803) Port 6 */ 619 - #define SEALEVEL_2803_7_PID 0X2873 /* SeaLINK+8 (2803) Port 7 */ 620 - #define SEALEVEL_2803_8_PID 0X2883 /* SeaLINK+8 (2803) Port 8 */ 614 + #define SEALEVEL_2803_2_PID 0X2823 /* SeaLINK+8 (2803) Port 2 */ 615 + #define SEALEVEL_2803_3_PID 0X2833 /* SeaLINK+8 (2803) Port 3 */ 616 + #define SEALEVEL_2803_4_PID 0X2843 /* SeaLINK+8 (2803) Port 4 */ 617 + #define SEALEVEL_2803_5_PID 0X2853 /* SeaLINK+8 (2803) Port 5 */ 618 + #define SEALEVEL_2803_6_PID 0X2863 /* SeaLINK+8 (2803) Port 6 */ 619 + #define SEALEVEL_2803_7_PID 0X2873 /* SeaLINK+8 (2803) Port 7 */ 620 + #define SEALEVEL_2803_8_PID 0X2883 /* SeaLINK+8 (2803) Port 8 */ 621 621 622 622 /* 623 623 * JETI SPECTROMETER SPECBOS 1201 ··· 1013 1013 */ 1014 1014 #define EVOLUTION_VID 0xDEEE /* Vendor ID */ 1015 1015 #define EVOLUTION_ER1_PID 0x0300 /* ER1 Control Module */ 1016 - #define EVO_8U232AM_PID 0x02FF /* Evolution robotics RCM2 (FT232AM)*/ 1016 + #define EVO_8U232AM_PID 0x02FF /* Evolution robotics RCM2 (FT232AM)*/ 1017 1017 #define EVO_HYBRID_PID 0x0302 /* Evolution robotics RCM4 PID (FT232BM)*/ 1018 1018 #define EVO_RCM4_PID 0x0303 /* Evolution robotics RCM4 PID */ 1019 1019