Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

leds: do not overflow sysfs buffer in led_trigger_show

Per the documentation, use scnprintf instead of sprintf to ensure there
is never more than PAGE_SIZE bytes of trigger names put into the
buffer.

Signed-off-by: Nathan Sullivan <nathan.sullivan@ni.com>
Signed-off-by: Zach Brown <zach.brown@ni.com>
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>

authored by

Nathan Sullivan and committed by
Jacek Anaszewski
3b9b9536 50237863

+7 -5
+7 -5
drivers/leds/led-triggers.c
··· 81 81 down_read(&led_cdev->trigger_lock); 82 82 83 83 if (!led_cdev->trigger) 84 - len += sprintf(buf+len, "[none] "); 84 + len += scnprintf(buf+len, PAGE_SIZE - len, "[none] "); 85 85 else 86 - len += sprintf(buf+len, "none "); 86 + len += scnprintf(buf+len, PAGE_SIZE - len, "none "); 87 87 88 88 list_for_each_entry(trig, &trigger_list, next_trig) { 89 89 if (led_cdev->trigger && !strcmp(led_cdev->trigger->name, 90 90 trig->name)) 91 - len += sprintf(buf+len, "[%s] ", trig->name); 91 + len += scnprintf(buf+len, PAGE_SIZE - len, "[%s] ", 92 + trig->name); 92 93 else 93 - len += sprintf(buf+len, "%s ", trig->name); 94 + len += scnprintf(buf+len, PAGE_SIZE - len, "%s ", 95 + trig->name); 94 96 } 95 97 up_read(&led_cdev->trigger_lock); 96 98 up_read(&triggers_list_lock); 97 99 98 - len += sprintf(len+buf, "\n"); 100 + len += scnprintf(len+buf, PAGE_SIZE - len, "\n"); 99 101 return len; 100 102 } 101 103 EXPORT_SYMBOL_GPL(led_trigger_show);