Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

cpuidle: mvebu: Fix duplicate flags assignment

The added '.flags' value is sometimes ignored here because
it gets overwritten by another initialization:

drivers/cpuidle/cpuidle-mvebu-v7.c:24:33: error: initialized field overwritten [-Werror=override-init]
24 | #define MVEBU_V7_FLAG_DEEP_IDLE 0x10000
| ^~~~~~~
drivers/cpuidle/cpuidle-mvebu-v7.c:69:43: note: in expansion of macro 'MVEBU_V7_FLAG_DEEP_IDLE'
...

Merge the two fields into one.

Fixes: 4ce40e9dbe83 ("cpuidle, armada: Push RCU-idle into driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20230117164642.1672784-1-arnd@kernel.org

authored by

Arnd Bergmann and committed by
Ingo Molnar
3b8645e9 79ba1e60

+4 -6
+4 -6
drivers/cpuidle/cpuidle-mvebu-v7.c
··· 52 52 .name = "armada_xp_idle", 53 53 .states[0] = ARM_CPUIDLE_WFI_STATE, 54 54 .states[1] = { 55 - .flags = CPUIDLE_FLAG_RCU_IDLE, 56 55 .enter = mvebu_v7_enter_idle, 57 56 .exit_latency = 100, 58 57 .power_usage = 50, 59 58 .target_residency = 1000, 59 + .flags = CPUIDLE_FLAG_RCU_IDLE, 60 60 .name = "MV CPU IDLE", 61 61 .desc = "CPU power down", 62 62 }, 63 63 .states[2] = { 64 - .flags = CPUIDLE_FLAG_RCU_IDLE, 65 64 .enter = mvebu_v7_enter_idle, 66 65 .exit_latency = 1000, 67 66 .power_usage = 5, 68 67 .target_residency = 10000, 69 - .flags = MVEBU_V7_FLAG_DEEP_IDLE, 68 + .flags = MVEBU_V7_FLAG_DEEP_IDLE | CPUIDLE_FLAG_RCU_IDLE, 70 69 .name = "MV CPU DEEP IDLE", 71 70 .desc = "CPU and L2 Fabric power down", 72 71 }, ··· 76 77 .name = "armada_370_idle", 77 78 .states[0] = ARM_CPUIDLE_WFI_STATE, 78 79 .states[1] = { 79 - .flags = CPUIDLE_FLAG_RCU_IDLE, 80 80 .enter = mvebu_v7_enter_idle, 81 81 .exit_latency = 100, 82 82 .power_usage = 5, 83 83 .target_residency = 1000, 84 - .flags = MVEBU_V7_FLAG_DEEP_IDLE, 84 + .flags = MVEBU_V7_FLAG_DEEP_IDLE | CPUIDLE_FLAG_RCU_IDLE, 85 85 .name = "Deep Idle", 86 86 .desc = "CPU and L2 Fabric power down", 87 87 }, ··· 91 93 .name = "armada_38x_idle", 92 94 .states[0] = ARM_CPUIDLE_WFI_STATE, 93 95 .states[1] = { 94 - .flags = CPUIDLE_FLAG_RCU_IDLE, 95 96 .enter = mvebu_v7_enter_idle, 96 97 .exit_latency = 10, 97 98 .power_usage = 5, 98 99 .target_residency = 100, 100 + .flags = CPUIDLE_FLAG_RCU_IDLE, 99 101 .name = "Idle", 100 102 .desc = "CPU and SCU power down", 101 103 },