[PATCH] scsi_ioctl: only warn for rejected commands

We should not be warning about commands that we allow, even if they are
unknown. So move the if-root-allow check up a notch.

Signed-off-by: Jens Axboe <axboe@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

authored by Jens Axboe and committed by Linus Torvalds 3b0e77bd 8aa19ad8

+4 -4
+4 -4
drivers/block/scsi_ioctl.c
··· 201 201 return 0; 202 202 } 203 203 204 + /* And root can do any command.. */ 205 + if (capable(CAP_SYS_RAWIO)) 206 + return 0; 207 + 204 208 if (!type) { 205 209 cmd_type[cmd[0]] = CMD_WARNED; 206 210 printk(KERN_WARNING "scsi: unknown opcode 0x%02x\n", cmd[0]); 207 211 } 208 - 209 - /* And root can do any command.. */ 210 - if (capable(CAP_SYS_RAWIO)) 211 - return 0; 212 212 213 213 /* Otherwise fail it with an "Operation not permitted" */ 214 214 return -EPERM;