Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

leds: lp8860: Check return value of devm_mutex_init()

devm_mutex_init() can fail. With CONFIG_DEBUG_MUTEXES=y the mutex will be
marked as unusable and trigger errors on usage.

Add the missed check.

Fixes: 87a59548af95 ("leds: lp8860: Use new mutex guards to cleanup function exits")
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Acked-by: Andrew Davis <afd@ti.com>
Acked-by: Lee Jones <lee@kernel.org>
Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
Link: https://lore.kernel.org/r/20250617-must_check-devm_mutex_init-v7-2-d9e449f4d224@weissschuh.net

authored by

Thomas Weißschuh and committed by
Boqun Feng
3b07bb90 d24a54e0

+3 -1
+3 -1
drivers/leds/leds-lp8860.c
··· 307 307 led->client = client; 308 308 led->led_dev.brightness_set_blocking = lp8860_brightness_set; 309 309 310 - devm_mutex_init(&client->dev, &led->lock); 310 + ret = devm_mutex_init(&client->dev, &led->lock); 311 + if (ret) 312 + return dev_err_probe(&client->dev, ret, "Failed to initialize lock\n"); 311 313 312 314 led->regmap = devm_regmap_init_i2c(client, &lp8860_regmap_config); 313 315 if (IS_ERR(led->regmap)) {