Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

libbpf: Rename internal memory-management helpers

Rename btf_add_mem() and btf_ensure_mem() helpers that abstract away details
of dynamically resizable memory to use libbpf_ prefix, as they are not
BTF-specific. No functional changes.

Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/20210318194036.3521577-4-andrii@kernel.org

authored by

Andrii Nakryiko and committed by
Alexei Starovoitov
3b029e06 f36e99a4

+21 -21
+12 -12
tools/lib/bpf/btf.c
··· 142 142 * On success, memory pointer to the beginning of unused memory is returned. 143 143 * On error, NULL is returned. 144 144 */ 145 - void *btf_add_mem(void **data, size_t *cap_cnt, size_t elem_sz, 146 - size_t cur_cnt, size_t max_cnt, size_t add_cnt) 145 + void *libbpf_add_mem(void **data, size_t *cap_cnt, size_t elem_sz, 146 + size_t cur_cnt, size_t max_cnt, size_t add_cnt) 147 147 { 148 148 size_t new_cnt; 149 149 void *new_data; ··· 179 179 /* Ensure given dynamically allocated memory region has enough allocated space 180 180 * to accommodate *need_cnt* elements of size *elem_sz* bytes each 181 181 */ 182 - int btf_ensure_mem(void **data, size_t *cap_cnt, size_t elem_sz, size_t need_cnt) 182 + int libbpf_ensure_mem(void **data, size_t *cap_cnt, size_t elem_sz, size_t need_cnt) 183 183 { 184 184 void *p; 185 185 186 186 if (need_cnt <= *cap_cnt) 187 187 return 0; 188 188 189 - p = btf_add_mem(data, cap_cnt, elem_sz, *cap_cnt, SIZE_MAX, need_cnt - *cap_cnt); 189 + p = libbpf_add_mem(data, cap_cnt, elem_sz, *cap_cnt, SIZE_MAX, need_cnt - *cap_cnt); 190 190 if (!p) 191 191 return -ENOMEM; 192 192 ··· 197 197 { 198 198 __u32 *p; 199 199 200 - p = btf_add_mem((void **)&btf->type_offs, &btf->type_offs_cap, sizeof(__u32), 201 - btf->nr_types, BTF_MAX_NR_TYPES, 1); 200 + p = libbpf_add_mem((void **)&btf->type_offs, &btf->type_offs_cap, sizeof(__u32), 201 + btf->nr_types, BTF_MAX_NR_TYPES, 1); 202 202 if (!p) 203 203 return -ENOMEM; 204 204 ··· 1586 1586 1587 1587 static void *btf_add_str_mem(struct btf *btf, size_t add_sz) 1588 1588 { 1589 - return btf_add_mem(&btf->strs_data, &btf->strs_data_cap, 1, 1590 - btf->hdr->str_len, BTF_MAX_STR_OFFSET, add_sz); 1589 + return libbpf_add_mem(&btf->strs_data, &btf->strs_data_cap, 1, 1590 + btf->hdr->str_len, BTF_MAX_STR_OFFSET, add_sz); 1591 1591 } 1592 1592 1593 1593 /* Find an offset in BTF string section that corresponds to a given string *s*. ··· 1683 1683 1684 1684 static void *btf_add_type_mem(struct btf *btf, size_t add_sz) 1685 1685 { 1686 - return btf_add_mem(&btf->types_data, &btf->types_data_cap, 1, 1687 - btf->hdr->type_len, UINT_MAX, add_sz); 1686 + return libbpf_add_mem(&btf->types_data, &btf->types_data_cap, 1, 1687 + btf->hdr->type_len, UINT_MAX, add_sz); 1688 1688 } 1689 1689 1690 1690 static __u32 btf_type_info(int kind, int vlen, int kflag) ··· 3208 3208 len = strlen(s) + 1; 3209 3209 3210 3210 new_off = d->strs_len; 3211 - p = btf_add_mem(&d->strs_data, &d->strs_cap, 1, new_off, BTF_MAX_STR_OFFSET, len); 3211 + p = libbpf_add_mem(&d->strs_data, &d->strs_cap, 1, new_off, BTF_MAX_STR_OFFSET, len); 3212 3212 if (!p) 3213 3213 return -ENOMEM; 3214 3214 ··· 3264 3264 } 3265 3265 3266 3266 if (!d->btf->base_btf) { 3267 - s = btf_add_mem(&d->strs_data, &d->strs_cap, 1, d->strs_len, BTF_MAX_STR_OFFSET, 1); 3267 + s = libbpf_add_mem(&d->strs_data, &d->strs_cap, 1, d->strs_len, BTF_MAX_STR_OFFSET, 1); 3268 3268 if (!s) 3269 3269 return -ENOMEM; 3270 3270 /* initial empty string */
+4 -4
tools/lib/bpf/btf_dump.c
··· 166 166 if (last_id <= d->last_id) 167 167 return 0; 168 168 169 - if (btf_ensure_mem((void **)&d->type_states, &d->type_states_cap, 170 - sizeof(*d->type_states), last_id + 1)) 169 + if (libbpf_ensure_mem((void **)&d->type_states, &d->type_states_cap, 170 + sizeof(*d->type_states), last_id + 1)) 171 171 return -ENOMEM; 172 - if (btf_ensure_mem((void **)&d->cached_names, &d->cached_names_cap, 173 - sizeof(*d->cached_names), last_id + 1)) 172 + if (libbpf_ensure_mem((void **)&d->cached_names, &d->cached_names_cap, 173 + sizeof(*d->cached_names), last_id + 1)) 174 174 return -ENOMEM; 175 175 176 176 if (d->last_id == 0) {
+2 -2
tools/lib/bpf/libbpf.c
··· 4867 4867 goto err_out; 4868 4868 } 4869 4869 4870 - err = btf_ensure_mem((void **)&obj->btf_modules, &obj->btf_module_cap, 4871 - sizeof(*obj->btf_modules), obj->btf_module_cnt + 1); 4870 + err = libbpf_ensure_mem((void **)&obj->btf_modules, &obj->btf_module_cap, 4871 + sizeof(*obj->btf_modules), obj->btf_module_cnt + 1); 4872 4872 if (err) 4873 4873 goto err_out; 4874 4874
+3 -3
tools/lib/bpf/libbpf_internal.h
··· 112 112 113 113 struct btf_type *btf_type_by_id(struct btf *btf, __u32 type_id); 114 114 115 - void *btf_add_mem(void **data, size_t *cap_cnt, size_t elem_sz, 116 - size_t cur_cnt, size_t max_cnt, size_t add_cnt); 117 - int btf_ensure_mem(void **data, size_t *cap_cnt, size_t elem_sz, size_t need_cnt); 115 + void *libbpf_add_mem(void **data, size_t *cap_cnt, size_t elem_sz, 116 + size_t cur_cnt, size_t max_cnt, size_t add_cnt); 117 + int libbpf_ensure_mem(void **data, size_t *cap_cnt, size_t elem_sz, size_t need_cnt); 118 118 119 119 static inline bool libbpf_validate_opts(const char *opts, 120 120 size_t opts_sz, size_t user_sz,