Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

sound/oss: Remove uncompilable DBG macro use

Most of it duplicates function tracing and one
of them has an uncompilable printf %P use.
Others have format/argument mismatches.

Remove unused DBG1 macro definition

Neaten uart401.c use of ok test around this
DBG macro removal.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

authored by

Joe Perches and committed by
Takashi Iwai
3af5d052 6ea0cae7

+2 -67
-4
sound/oss/ad1848.c
··· 50 50 #include <linux/pnp.h> 51 51 #include <linux/spinlock.h> 52 52 53 - #define DEB(x) 54 - #define DEB1(x) 55 53 #include "sound_config.h" 56 54 57 55 #include "ad1848.h" ··· 1013 1015 unsigned long flags; 1014 1016 ad1848_info *devc = (ad1848_info *) audio_devs[dev]->devc; 1015 1017 ad1848_port_info *portc = (ad1848_port_info *) audio_devs[dev]->portc; 1016 - 1017 - DEB(printk("ad1848_close(void)\n")); 1018 1018 1019 1019 devc->intr_active = 0; 1020 1020 ad1848_halt(dev);
-3
sound/oss/opl3.c
··· 275 275 devc->v_alloc->map[voice] = 0; 276 276 277 277 map = &pv_map[devc->lv_map[voice]]; 278 - DEB(printk("Kill note %d\n", voice)); 279 278 280 279 if (map->voice_mode == 0) 281 280 return 0; ··· 871 872 return; 872 873 873 874 map = &pv_map[devc->lv_map[voice]]; 874 - 875 - DEB(printk("Aftertouch %d\n", voice)); 876 875 877 876 if (map->voice_mode == 0) 878 877 return;
-9
sound/oss/pas2_mixer.c
··· 21 21 22 22 #include "pas2.h" 23 23 24 - #ifndef DEB 25 - #define DEB(what) /* (what) */ 26 - #endif 27 - 28 24 extern int pas_translate_code; 29 25 extern char pas_model; 30 26 extern int *pas_osp; ··· 116 120 { 117 121 int left, right, devmask, changed, i, mixer = 0; 118 122 119 - DEB(printk("static int pas_mixer_set(int whichDev = %d, unsigned int level = %X)\n", whichDev, level)); 120 - 121 123 left = level & 0x7f; 122 124 right = (level & 0x7f00) >> 8; 123 125 ··· 201 207 { 202 208 int foo; 203 209 204 - DEB(printk("pas2_mixer.c: void pas_mixer_reset(void)\n")); 205 - 206 210 for (foo = 0; foo < SOUND_MIXER_NRDEVICES; foo++) 207 211 pas_mixer_set(foo, levels[foo]); 208 212 ··· 212 220 int level,v ; 213 221 int __user *p = (int __user *)arg; 214 222 215 - DEB(printk("pas2_mixer.c: int pas_mixer_ioctl(unsigned int cmd = %X, unsigned int arg = %X)\n", cmd, arg)); 216 223 if (cmd == SOUND_MIXER_PRIVATE1) { /* Set loudness bit */ 217 224 if (get_user(level, p)) 218 225 return -EFAULT;
-18
sound/oss/pas2_pcm.c
··· 22 22 23 23 #include "pas2.h" 24 24 25 - #ifndef DEB 26 - #define DEB(WHAT) 27 - #endif 28 - 29 25 #define PAS_PCM_INTRBITS (0x08) 30 26 /* 31 27 * Sample buffer timer interrupt enable ··· 152 156 int val, ret; 153 157 int __user *p = arg; 154 158 155 - DEB(printk("pas2_pcm.c: static int pas_audio_ioctl(unsigned int cmd = %X, unsigned int arg = %X)\n", cmd, arg)); 156 - 157 159 switch (cmd) 158 160 { 159 161 case SOUND_PCM_WRITE_RATE: ··· 198 204 199 205 static void pas_audio_reset(int dev) 200 206 { 201 - DEB(printk("pas2_pcm.c: static void pas_audio_reset(void)\n")); 202 - 203 207 pas_write(pas_read(0xF8A) & ~0x40, 0xF8A); /* Disable PCM */ 204 208 } 205 209 ··· 205 213 { 206 214 int err; 207 215 unsigned long flags; 208 - 209 - DEB(printk("pas2_pcm.c: static int pas_audio_open(int mode = %X)\n", mode)); 210 216 211 217 spin_lock_irqsave(&pas_lock, flags); 212 218 if (pcm_busy) ··· 229 239 { 230 240 unsigned long flags; 231 241 232 - DEB(printk("pas2_pcm.c: static void pas_audio_close(void)\n")); 233 - 234 242 spin_lock_irqsave(&pas_lock, flags); 235 243 236 244 pas_audio_reset(dev); ··· 243 255 int intrflag) 244 256 { 245 257 unsigned long flags, cnt; 246 - 247 - DEB(printk("pas2_pcm.c: static void pas_audio_output_block(char *buf = %P, int count = %X)\n", buf, count)); 248 258 249 259 cnt = count; 250 260 if (audio_devs[dev]->dmap_out->dma > 3) ··· 288 302 { 289 303 unsigned long flags; 290 304 int cnt; 291 - 292 - DEB(printk("pas2_pcm.c: static void pas_audio_start_input(char *buf = %P, int count = %X)\n", buf, count)); 293 305 294 306 cnt = count; 295 307 if (audio_devs[dev]->dmap_out->dma > 3) ··· 372 388 373 389 void __init pas_pcm_init(struct address_info *hw_config) 374 390 { 375 - DEB(printk("pas2_pcm.c: long pas_pcm_init()\n")); 376 - 377 391 pcm_bitsok = 8; 378 392 if (pas_read(0xEF8B) & 0x08) 379 393 pcm_bitsok |= 16;
-4
sound/oss/sb_common.c
··· 226 226 { 227 227 int loopc; 228 228 229 - DEB(printk("Entered sb_dsp_reset()\n")); 230 - 231 229 if (devc->model == MDL_ESS) return ess_dsp_reset (devc); 232 230 233 231 /* This is only for non-ESS chips */ ··· 243 245 DDB(printk("sb: No response to RESET\n")); 244 246 return 0; /* Sorry */ 245 247 } 246 - 247 - DEB(printk("sb_dsp_reset() OK\n")); 248 248 249 249 return 1; 250 250 }
-4
sound/oss/sb_ess.c
··· 865 865 ess_show_mixerregs (devc); 866 866 #endif 867 867 868 - DEB(printk("Entered ess_dsp_reset()\n")); 869 - 870 868 outb(3, DSP_RESET); /* Reset FIFO too */ 871 869 872 870 udelay(10); ··· 878 880 return 0; /* Sorry */ 879 881 } 880 882 ess_extended (devc); 881 - 882 - DEB(printk("sb_dsp_reset() OK\n")); 883 883 884 884 #ifdef FKS_LOGGING 885 885 printk(KERN_INFO "FKS: dsp_reset 2\n");
-6
sound/oss/sequencer.c
··· 216 216 217 217 dev = dev >> 4; 218 218 219 - DEB(printk("sequencer_write(dev=%d, count=%d)\n", dev, count)); 220 - 221 219 if (mode == OPEN_READ) 222 220 return -EIO; 223 221 ··· 957 959 dev = dev >> 4; 958 960 mode = translate_mode(file); 959 961 960 - DEB(printk("sequencer_open(dev=%d)\n", dev)); 961 - 962 962 if (!sequencer_ok) 963 963 { 964 964 /* printk("Sound card: sequencer not initialized\n");*/ ··· 1128 1132 int mode = translate_mode(file); 1129 1133 1130 1134 dev = dev >> 4; 1131 - 1132 - DEB(printk("sequencer_release(dev=%d)\n", dev)); 1133 1135 1134 1136 /* 1135 1137 * Wait until the queue is empty (if we don't have nonblock)
-4
sound/oss/sound_config.h
··· 123 123 #include "sound_calls.h" 124 124 #include "dev_table.h" 125 125 126 - #ifndef DEB 127 - #define DEB(x) 128 - #endif 129 - 130 126 #ifndef DDB 131 127 #define DDB(x) do {} while (0) 132 128 #endif
-6
sound/oss/soundcard.c
··· 154 154 155 155 mutex_lock(&soundcard_mutex); 156 156 157 - DEB(printk("sound_read(dev=%d, count=%d)\n", dev, count)); 158 157 switch (dev & 0x0f) { 159 158 case SND_DEV_DSP: 160 159 case SND_DEV_DSP16: ··· 179 180 int ret = -EINVAL; 180 181 181 182 mutex_lock(&soundcard_mutex); 182 - DEB(printk("sound_write(dev=%d, count=%d)\n", dev, count)); 183 183 switch (dev & 0x0f) { 184 184 case SND_DEV_SEQ: 185 185 case SND_DEV_SEQ2: ··· 204 206 int dev = iminor(inode); 205 207 int retval; 206 208 207 - DEB(printk("sound_open(dev=%d)\n", dev)); 208 209 if ((dev >= SND_NDEVS) || (dev < 0)) { 209 210 printk(KERN_ERR "Invalid minor device %d\n", dev); 210 211 return -ENXIO; ··· 254 257 int dev = iminor(inode); 255 258 256 259 mutex_lock(&soundcard_mutex); 257 - DEB(printk("sound_release(dev=%d)\n", dev)); 258 260 switch (dev & 0x0f) { 259 261 case SND_DEV_CTL: 260 262 module_put(mixer_devs[dev >> 4]->owner); ··· 347 351 if (!access_ok(VERIFY_WRITE, p, len)) 348 352 return -EFAULT; 349 353 } 350 - DEB(printk("sound_ioctl(dev=%d, cmd=0x%x, arg=0x%x)\n", dev, cmd, arg)); 351 354 if (cmd == OSS_GETVERSION) 352 355 return __put_user(SOUND_VERSION, (int __user *)p); 353 356 ··· 404 409 struct inode *inode = file_inode(file); 405 410 int dev = iminor(inode); 406 411 407 - DEB(printk("sound_poll(dev=%d)\n", dev)); 408 412 switch (dev & 0x0f) { 409 413 case SND_DEV_SEQ: 410 414 case SND_DEV_SEQ2:
+2 -9
sound/oss/uart401.c
··· 274 274 } 275 275 } 276 276 277 - 277 + /* Flush input before enabling interrupts */ 278 278 if (ok) 279 - { 280 - DEB(printk("Reset UART401 OK\n")); 281 - } 279 + uart401_input_loop(devc); 282 280 else 283 281 DDB(printk("Reset UART401 failed - No hardware detected.\n")); 284 - 285 - if (ok) 286 - uart401_input_loop(devc); /* 287 - * Flush input before enabling interrupts 288 - */ 289 282 290 283 return ok; 291 284 }