tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

macintosh: Switch to use for_each_child_of_node() macro

Use for_each_child_of_node() macro instead of open coding it.
No functional change.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220916141638.685575-1-yangyingliang@huawei.com

authored by

Yang Yingliang and committed by
Michael Ellerman 3aa16303 e3e528d2

+4 -6
+4 -6
drivers/macintosh/windfarm_smu_controls.c
··· 266 266 return -ENODEV; 267 267 268 268 /* Look for RPM fans */ 269 - for (fans = NULL; (fans = of_get_next_child(smu, fans)) != NULL;) 269 + for_each_child_of_node(smu, fans) 270 270 if (of_node_name_eq(fans, "rpm-fans") || 271 271 of_device_is_compatible(fans, "smu-rpm-fans")) 272 272 break; 273 - for (fan = NULL; 274 - fans && (fan = of_get_next_child(fans, fan)) != NULL;) { 273 + for_each_child_of_node(fans, fan) { 275 274 struct smu_fan_control *fct; 276 275 277 276 fct = smu_fan_create(fan, 0); ··· 285 286 286 287 287 288 /* Look for PWM fans */ 288 - for (fans = NULL; (fans = of_get_next_child(smu, fans)) != NULL;) 289 + for_each_child_of_node(smu, fans) 289 290 if (of_node_name_eq(fans, "pwm-fans")) 290 291 break; 291 - for (fan = NULL; 292 - fans && (fan = of_get_next_child(fans, fan)) != NULL;) { 292 + for_each_child_of_node(fans, fan) { 293 293 struct smu_fan_control *fct; 294 294 295 295 fct = smu_fan_create(fan, 1);