RAS/CEC: Correct ce_add_elem()'s returned values

ce_add_elem() uses different return values to signal a result from
adding an element to the collector. Commit in Fixes: broke the case
where the element being added is not found in the array. Correct that.

[ bp: Rewrite commit message, add kernel-doc comments. ]

Fixes: de0e0624d86f ("RAS/CEC: Check count_threshold unconditionally")
Signed-off-by: William Roche <william.roche@oracle.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: <stable@vger.kernel.org>
Link: https://lkml.kernel.org/r/1617722939-29670-1-git-send-email-william.roche@oracle.com

authored by William Roche and committed by Borislav Petkov 3a62583c e49d033b

Changed files
+12 -3
drivers
ras
+12 -3
drivers/ras/cec.c
··· 309 309 return ret; 310 310 } 311 311 312 + /** 313 + * cec_add_elem - Add an element to the CEC array. 314 + * @pfn: page frame number to insert 315 + * 316 + * Return values: 317 + * - <0: on error 318 + * - 0: on success 319 + * - >0: when the inserted pfn was offlined 320 + */ 312 321 static int cec_add_elem(u64 pfn) 313 322 { 314 323 struct ce_array *ca = &ce_arr; 324 + int count, err, ret = 0; 315 325 unsigned int to = 0; 316 - int count, ret = 0; 317 326 318 327 /* 319 328 * We can be called very early on the identify_cpu() path where we are ··· 339 330 if (ca->n == MAX_ELEMS) 340 331 WARN_ON(!del_lru_elem_unlocked(ca)); 341 332 342 - ret = find_elem(ca, pfn, &to); 343 - if (ret < 0) { 333 + err = find_elem(ca, pfn, &to); 334 + if (err < 0) { 344 335 /* 345 336 * Shift range [to-end] to make room for one more element. 346 337 */