Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/mcde: Fix refcount leak in mcde_dsi_bind

Every iteration of for_each_available_child_of_node() decrements
the reference counter of the previous node. There is no decrement
when break out from the loop and results in refcount leak.
Add missing of_node_put() to fix this.

Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220525115411.65455-1-linmq006@gmail.com

authored by

Miaoqian Lin and committed by
Linus Walleij
3a149169 e5d6eeea

+1
+1
drivers/gpu/drm/mcde/mcde_dsi.c
··· 1111 1111 bridge = of_drm_find_bridge(child); 1112 1112 if (!bridge) { 1113 1113 dev_err(dev, "failed to find bridge\n"); 1114 + of_node_put(child); 1114 1115 return -EINVAL; 1115 1116 } 1116 1117 }