Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

selftests: membarrier: return Kselftest Skip code for skipped tests

When membarrier test is skipped because of unmet dependencies and/or
unsupported configuration, it exits with error which is treated as a
fail by the Kselftest framework. This leads to false negative result
even when the test could not be run.

Change it to return kselftest skip code when a test gets skipped to
clearly report that the test could not be run.

Change it to use ksft_exit_skip() when the test is skipped.

Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org>

+3 -4
+3 -4
tools/testing/selftests/membarrier/membarrier_test.c
··· 293 293 } 294 294 ksft_exit_fail_msg("sys_membarrier() failed\n"); 295 295 } 296 - if (!(ret & MEMBARRIER_CMD_GLOBAL)) { 297 - ksft_test_result_fail("sys_membarrier() CMD_GLOBAL query failed\n"); 298 - ksft_exit_fail_msg("sys_membarrier is not supported.\n"); 299 - } 296 + if (!(ret & MEMBARRIER_CMD_GLOBAL)) 297 + ksft_exit_skip( 298 + "sys_membarrier unsupported: CMD_GLOBAL not found.\n"); 300 299 301 300 ksft_test_result_pass("sys_membarrier available\n"); 302 301 return 0;