Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

pinctrl: intel: check REVID register value for device presence

Use the value read from the REVID register in order to check for the
presence of the device. A read of all ones is treated as if the device
is not present, and hence probing is ended.

This fixes an issue when running as a Xen PVH dom0, where the ACPI
DSDT table is provided unmodified to dom0 and hence contains the
pinctrl devices, but the MMIO region(s) containing the device
registers might not be mapped in the guest physical memory map if such
region(s) are not exposed on a PCI device BAR or marked as reserved in
the host memory map.

Fixes: 91d898e51e60 ("pinctrl: intel: Convert capability list to features")
Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

authored by

Roger Pau Monne and committed by
Andy Shevchenko
39c1f1bd 77e14126

+6 -1
+6 -1
drivers/pinctrl/intel/pinctrl-intel.c
··· 1493 1493 if (IS_ERR(regs)) 1494 1494 return PTR_ERR(regs); 1495 1495 1496 - /* Determine community features based on the revision */ 1496 + /* 1497 + * Determine community features based on the revision. 1498 + * A value of all ones means the device is not present. 1499 + */ 1497 1500 value = readl(regs + REVID); 1501 + if (value == ~0u) 1502 + return -ENODEV; 1498 1503 if (((value & REVID_MASK) >> REVID_SHIFT) >= 0x94) { 1499 1504 community->features |= PINCTRL_FEATURE_DEBOUNCE; 1500 1505 community->features |= PINCTRL_FEATURE_1K_PD;