Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

usb: cdns3: trace: delete the trace parameter for request->trb

It is not correct using %pa to print virtual address of request->trb, and
it is hard to print its physical address due to the virtual address is
zero before using. It could use index (start_trb/end_trb) to know the
current trb position, so no matter virtual address or physical address
for request-trb is not so meaningful.

Reported-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Peter Chen <peter.chen@kernel.org>

+1 -4
+1 -4
drivers/usb/cdns3/cdns3-trace.h
··· 214 214 __field(int, no_interrupt) 215 215 __field(int, start_trb) 216 216 __field(int, end_trb) 217 - __field(struct cdns3_trb *, start_trb_addr) 218 217 __field(int, flags) 219 218 __field(unsigned int, stream_id) 220 219 ), ··· 229 230 __entry->no_interrupt = req->request.no_interrupt; 230 231 __entry->start_trb = req->start_trb; 231 232 __entry->end_trb = req->end_trb; 232 - __entry->start_trb_addr = req->trb; 233 233 __entry->flags = req->flags; 234 234 __entry->stream_id = req->request.stream_id; 235 235 ), 236 236 TP_printk("%s: req: %p, req buff %p, length: %u/%u %s%s%s, status: %d," 237 - " trb: [start:%d, end:%d: virt addr %pa], flags:%x SID: %u", 237 + " trb: [start:%d, end:%d], flags:%x SID: %u", 238 238 __get_str(name), __entry->req, __entry->buf, __entry->actual, 239 239 __entry->length, 240 240 __entry->zero ? "Z" : "z", ··· 242 244 __entry->status, 243 245 __entry->start_trb, 244 246 __entry->end_trb, 245 - __entry->start_trb_addr, 246 247 __entry->flags, 247 248 __entry->stream_id 248 249 )