Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

perf build: Make minimal shellcheck version to v0.6.0

The perf build failed due to the shellcheck on my machine (v0.4.6 on Ubuntu
18.04.1 LTS) doesn't support -a/--check-sourced and -S/--severity option.

These two options are introduced in shellcheck v0.4.7 and v0.6.0
respectively. So restrict the minimal version of shellcheck to v0.6.0.

Fixes: b809fc656e763296 ("perf build: Shellcheck support for OUTPUT directory")
Reviewed-by: Ian Rogers <irogers@google.com>
Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Junhao He <hejunhao3@huawei.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: linuxarm@huawei.com
Link: https://lore.kernel.org/r/20240122080406.28678-1-yangyicong@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

authored by

Yicong Yang and committed by
Arnaldo Carvalho de Melo
39af6741 1233d1d5

+10
+10
tools/perf/Makefile.perf
··· 236 236 SHELLCHECK := $(shell which shellcheck 2> /dev/null) 237 237 endif 238 238 239 + # shellcheck is using in tools/perf/tests/Build with option -a/--check-sourced ( 240 + # introduced in v0.4.7) and -S/--severity (introduced in v0.6.0). So make the 241 + # minimal shellcheck version as v0.6.0. 242 + ifneq ($(SHELLCHECK),) 243 + ifeq ($(shell expr $(shell $(SHELLCHECK) --version | grep version: | \ 244 + sed -e 's/.\+ \([0-9]\+\).\([0-9]\+\).\([0-9]\+\)/\1\2\3/g') \< 060), 1) 245 + SHELLCHECK := 246 + endif 247 + endif 248 + 239 249 export srctree OUTPUT RM CC CXX LD AR CFLAGS CXXFLAGS V BISON FLEX AWK 240 250 export HOSTCC HOSTLD HOSTAR HOSTCFLAGS SHELLCHECK 241 251