Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/i915/display: use drm->debugfs_root for creating debugfs files

Since commit 0b30d57acafc ("drm/debugfs: rework debugfs directory
creation v5") we should be using drm->debugfs_root instead of
minor->debugfs_root for creating debugfs files.

As a rule of thumb, use a local variable when there are two or more
uses, otherwise just have the single reference inline.

Drop drm/drm_file.h include where possible.

Reviewed-by: Luca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/e8268546ec2a2941a3dc43c2fdc60f678dc03fce.1753782998.git.jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>

+26 -40
+1 -3
drivers/gpu/drm/i915/display/intel_bios.c
··· 3744 3744 3745 3745 void intel_bios_debugfs_register(struct intel_display *display) 3746 3746 { 3747 - struct drm_minor *minor = display->drm->primary; 3748 - 3749 - debugfs_create_file("i915_vbt", 0444, minor->debugfs_root, 3747 + debugfs_create_file("i915_vbt", 0444, display->drm->debugfs_root, 3750 3748 display, &intel_bios_vbt_fops); 3751 3749 }
+1 -3
drivers/gpu/drm/i915/display/intel_cdclk.c
··· 3627 3627 3628 3628 void intel_cdclk_debugfs_register(struct intel_display *display) 3629 3629 { 3630 - struct drm_minor *minor = display->drm->primary; 3631 - 3632 - debugfs_create_file("i915_cdclk_info", 0444, minor->debugfs_root, 3630 + debugfs_create_file("i915_cdclk_info", 0444, display->drm->debugfs_root, 3633 3631 display, &i915_cdclk_info_fops); 3634 3632 } 3635 3633
+3 -3
drivers/gpu/drm/i915/display/intel_display_debugfs.c
··· 820 820 821 821 void intel_display_debugfs_register(struct intel_display *display) 822 822 { 823 - struct drm_minor *minor = display->drm->primary; 823 + struct dentry *debugfs_root = display->drm->debugfs_root; 824 824 825 - debugfs_create_file("i915_fifo_underrun_reset", 0644, minor->debugfs_root, 825 + debugfs_create_file("i915_fifo_underrun_reset", 0644, debugfs_root, 826 826 display, &i915_fifo_underrun_reset_ops); 827 827 828 828 drm_debugfs_create_files(intel_display_debugfs_list, 829 829 ARRAY_SIZE(intel_display_debugfs_list), 830 - minor->debugfs_root, minor); 830 + debugfs_root, display->drm->primary); 831 831 832 832 intel_bios_debugfs_register(display); 833 833 intel_cdclk_debugfs_register(display);
+3 -4
drivers/gpu/drm/i915/display/intel_display_debugfs_params.c
··· 7 7 #include <linux/kernel.h> 8 8 9 9 #include <drm/drm_drv.h> 10 - #include <drm/drm_file.h> 11 10 12 11 #include "intel_display_core.h" 13 12 #include "intel_display_debugfs_params.h" ··· 153 154 /* add a subdirectory with files for each intel display param */ 154 155 void intel_display_debugfs_params(struct intel_display *display) 155 156 { 156 - struct drm_minor *minor = display->drm->primary; 157 + struct dentry *debugfs_root = display->drm->debugfs_root; 157 158 struct dentry *dir; 158 159 char dirname[16]; 159 160 160 161 snprintf(dirname, sizeof(dirname), "%s_params", display->drm->driver->name); 161 - dir = debugfs_lookup(dirname, minor->debugfs_root); 162 + dir = debugfs_lookup(dirname, debugfs_root); 162 163 if (!dir) 163 - dir = debugfs_create_dir(dirname, minor->debugfs_root); 164 + dir = debugfs_create_dir(dirname, debugfs_root); 164 165 if (IS_ERR(dir)) 165 166 return; 166 167
+1 -3
drivers/gpu/drm/i915/display/intel_dmc.c
··· 1603 1603 1604 1604 void intel_dmc_debugfs_register(struct intel_display *display) 1605 1605 { 1606 - struct drm_minor *minor = display->drm->primary; 1607 - 1608 - debugfs_create_file("i915_dmc_info", 0444, minor->debugfs_root, 1606 + debugfs_create_file("i915_dmc_info", 0444, display->drm->debugfs_root, 1609 1607 display, &intel_dmc_debugfs_status_fops); 1610 1608 } 1611 1609
+1 -3
drivers/gpu/drm/i915/display/intel_dp_test.c
··· 6 6 #include <drm/display/drm_dp.h> 7 7 #include <drm/display/drm_dp_helper.h> 8 8 #include <drm/drm_edid.h> 9 - #include <drm/drm_file.h> 10 9 #include <drm/drm_print.h> 11 10 #include <drm/drm_probe_helper.h> 12 11 ··· 752 753 753 754 void intel_dp_test_debugfs_register(struct intel_display *display) 754 755 { 755 - struct drm_minor *minor = display->drm->primary; 756 756 int i; 757 757 758 758 for (i = 0; i < ARRAY_SIZE(intel_display_debugfs_files); i++) { 759 759 debugfs_create_file(intel_display_debugfs_files[i].name, 760 760 0644, 761 - minor->debugfs_root, 761 + display->drm->debugfs_root, 762 762 display, 763 763 intel_display_debugfs_files[i].fops); 764 764 }
+1 -2
drivers/gpu/drm/i915/display/intel_fbc.c
··· 2240 2240 /* FIXME: remove this once igt is on board with per-crtc stuff */ 2241 2241 void intel_fbc_debugfs_register(struct intel_display *display) 2242 2242 { 2243 - struct drm_minor *minor = display->drm->primary; 2244 2243 struct intel_fbc *fbc; 2245 2244 2246 2245 fbc = display->fbc[INTEL_FBC_A]; 2247 2246 if (fbc) 2248 - intel_fbc_debugfs_add(fbc, minor->debugfs_root); 2247 + intel_fbc_debugfs_add(fbc, display->drm->debugfs_root); 2249 2248 }
+4 -4
drivers/gpu/drm/i915/display/intel_hotplug.c
··· 1332 1332 1333 1333 void intel_hpd_debugfs_register(struct intel_display *display) 1334 1334 { 1335 - struct drm_minor *minor = display->drm->primary; 1335 + struct dentry *debugfs_root = display->drm->debugfs_root; 1336 1336 1337 - debugfs_create_file("i915_hpd_storm_ctl", 0644, minor->debugfs_root, 1337 + debugfs_create_file("i915_hpd_storm_ctl", 0644, debugfs_root, 1338 1338 display, &i915_hpd_storm_ctl_fops); 1339 - debugfs_create_file("i915_hpd_short_storm_ctl", 0644, minor->debugfs_root, 1339 + debugfs_create_file("i915_hpd_short_storm_ctl", 0644, debugfs_root, 1340 1340 display, &i915_hpd_short_storm_ctl_fops); 1341 - debugfs_create_bool("i915_ignore_long_hpd", 0644, minor->debugfs_root, 1341 + debugfs_create_bool("i915_ignore_long_hpd", 0644, debugfs_root, 1342 1342 &display->hotplug.ignore_long_hpd); 1343 1343 }
+1 -3
drivers/gpu/drm/i915/display/intel_opregion.c
··· 1299 1299 1300 1300 void intel_opregion_debugfs_register(struct intel_display *display) 1301 1301 { 1302 - struct drm_minor *minor = display->drm->primary; 1303 - 1304 - debugfs_create_file("i915_opregion", 0444, minor->debugfs_root, 1302 + debugfs_create_file("i915_opregion", 0444, display->drm->debugfs_root, 1305 1303 display, &intel_opregion_fops); 1306 1304 }
+3 -3
drivers/gpu/drm/i915/display/intel_psr.c
··· 4132 4132 4133 4133 void intel_psr_debugfs_register(struct intel_display *display) 4134 4134 { 4135 - struct drm_minor *minor = display->drm->primary; 4135 + struct dentry *debugfs_root = display->drm->debugfs_root; 4136 4136 4137 - debugfs_create_file("i915_edp_psr_debug", 0644, minor->debugfs_root, 4137 + debugfs_create_file("i915_edp_psr_debug", 0644, debugfs_root, 4138 4138 display, &i915_edp_psr_debug_fops); 4139 4139 4140 - debugfs_create_file("i915_edp_psr_status", 0444, minor->debugfs_root, 4140 + debugfs_create_file("i915_edp_psr_status", 0444, debugfs_root, 4141 4141 display, &i915_edp_psr_status_fops); 4142 4142 } 4143 4143
+4 -5
drivers/gpu/drm/i915/display/intel_wm.c
··· 5 5 6 6 #include <linux/debugfs.h> 7 7 8 - #include <drm/drm_file.h> 9 8 #include <drm/drm_print.h> 10 9 11 10 #include "i9xx_wm.h" ··· 389 390 390 391 void intel_wm_debugfs_register(struct intel_display *display) 391 392 { 392 - struct drm_minor *minor = display->drm->primary; 393 + struct dentry *debugfs_root = display->drm->debugfs_root; 393 394 394 - debugfs_create_file("i915_pri_wm_latency", 0644, minor->debugfs_root, 395 + debugfs_create_file("i915_pri_wm_latency", 0644, debugfs_root, 395 396 display, &i915_pri_wm_latency_fops); 396 397 397 - debugfs_create_file("i915_spr_wm_latency", 0644, minor->debugfs_root, 398 + debugfs_create_file("i915_spr_wm_latency", 0644, debugfs_root, 398 399 display, &i915_spr_wm_latency_fops); 399 400 400 - debugfs_create_file("i915_cur_wm_latency", 0644, minor->debugfs_root, 401 + debugfs_create_file("i915_cur_wm_latency", 0644, debugfs_root, 401 402 display, &i915_cur_wm_latency_fops); 402 403 403 404 skl_watermark_debugfs_register(display);
+3 -4
drivers/gpu/drm/i915/display/skl_watermark.c
··· 6 6 #include <linux/debugfs.h> 7 7 8 8 #include <drm/drm_blend.h> 9 - #include <drm/drm_file.h> 10 9 #include <drm/drm_print.h> 11 10 12 11 #include "soc/intel_dram.h" ··· 4032 4033 4033 4034 void skl_watermark_debugfs_register(struct intel_display *display) 4034 4035 { 4035 - struct drm_minor *minor = display->drm->primary; 4036 + struct dentry *debugfs_root = display->drm->debugfs_root; 4036 4037 4037 4038 if (HAS_IPC(display)) 4038 - debugfs_create_file("i915_ipc_status", 0644, minor->debugfs_root, 4039 + debugfs_create_file("i915_ipc_status", 0644, debugfs_root, 4039 4040 display, &skl_watermark_ipc_status_fops); 4040 4041 4041 4042 if (HAS_SAGV(display)) 4042 - debugfs_create_file("i915_sagv_status", 0444, minor->debugfs_root, 4043 + debugfs_create_file("i915_sagv_status", 0444, debugfs_root, 4043 4044 display, &intel_sagv_status_fops); 4044 4045 } 4045 4046