Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

bnx2x: Fix Multi-Cos

Apparently multi-cos isn't working for bnx2x quite some time -
driver implements ndo_select_queue() to allow queue-selection
for FCoE, but the regular L2 flow would cause it to modulo the
fallback's result by the number of queues.
The fallback would return a queue matching the needed tc
[via __skb_tx_hash()], but since the modulo is by the number of TSS
queues where number of TCs is not accounted, transmission would always
be done by a queue configured into using TC0.

Fixes: ada7c19e6d27 ("bnx2x: use XPS if possible for bnx2x_select_queue instead of pure hash")
Signed-off-by: Yuval Mintz <Yuval.Mintz@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Mintz, Yuval and committed by
David S. Miller
3968d389 2b7ea64f

+1 -1
+1 -1
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
··· 1926 1926 } 1927 1927 1928 1928 /* select a non-FCoE queue */ 1929 - return fallback(dev, skb) % BNX2X_NUM_ETH_QUEUES(bp); 1929 + return fallback(dev, skb) % (BNX2X_NUM_ETH_QUEUES(bp) * bp->max_cos); 1930 1930 } 1931 1931 1932 1932 void bnx2x_set_num_queues(struct bnx2x *bp)