Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

staging: use eth_hw_addr_set() for dev->addr_len cases

Convert all staging drivers from memcpy(... dev->addr_len)
to eth_hw_addr_set():

@@
expression dev, np;
@@
- memcpy(dev->dev_addr, np, dev->addr_len)
+ eth_hw_addr_set(dev, np)

Manually confirmed these are all etherdevices.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Link: https://lore.kernel.org/r/20211019171243.1412240-4-kuba@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Jakub Kicinski and committed by
Greg Kroah-Hartman
3928f64b 349f631d

+5 -9
+1 -1
drivers/staging/ks7010/ks_wlan_net.c
··· 2490 2490 2491 2491 if (netif_running(dev)) 2492 2492 return -EBUSY; 2493 - memcpy(dev->dev_addr, mac_addr->sa_data, dev->addr_len); 2493 + eth_hw_addr_set(dev, mac_addr->sa_data); 2494 2494 ether_addr_copy(priv->eth_addr, mac_addr->sa_data); 2495 2495 2496 2496 priv->mac_address_valid = false;
+3 -7
drivers/staging/qlge/qlge_main.c
··· 724 724 goto exit; 725 725 } 726 726 727 - memcpy(qdev->ndev->dev_addr, 728 - mac_addr, 729 - qdev->ndev->addr_len); 727 + eth_hw_addr_set(qdev->ndev, mac_addr); 730 728 731 729 exit: 732 730 qlge_sem_unlock(qdev, SEM_FLASH_MASK); ··· 772 774 goto exit; 773 775 } 774 776 775 - memcpy(qdev->ndev->dev_addr, 776 - qdev->flash.flash_params_8012.mac_addr, 777 - qdev->ndev->addr_len); 777 + eth_hw_addr_set(qdev->ndev, qdev->flash.flash_params_8012.mac_addr); 778 778 779 779 exit: 780 780 qlge_sem_unlock(qdev, SEM_FLASH_MASK); ··· 4210 4214 4211 4215 if (!is_valid_ether_addr(addr->sa_data)) 4212 4216 return -EADDRNOTAVAIL; 4213 - memcpy(ndev->dev_addr, addr->sa_data, ndev->addr_len); 4217 + eth_hw_addr_set(ndev, addr->sa_data); 4214 4218 /* Update local copy of current mac address. */ 4215 4219 memcpy(qdev->current_mac_addr, ndev->dev_addr, ndev->addr_len); 4216 4220
+1 -1
drivers/staging/wlan-ng/p80211netdev.c
··· 616 616 result = -EADDRNOTAVAIL; 617 617 } else { 618 618 /* everything's ok, change the addr in netdev */ 619 - memcpy(dev->dev_addr, new_addr->sa_data, dev->addr_len); 619 + eth_hw_addr_set(dev, new_addr->sa_data); 620 620 } 621 621 622 622 return result;