Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

selftests: mptcp: join: mark 'fail' tests as flaky

These tests are rarely unstable. It depends on the CI running the tests,
especially if it is also busy doing other tasks in parallel, and if a
debug kernel config is being used.

It looks like this issue is sometimes present with the NetDev CI. While
this is being investigated, the tests are marked as flaky not to create
noises on such CIs.

Fixes: b6e074e171bc ("selftests: mptcp: add infinite map testcase")
Link: https://github.com/multipath-tcp/mptcp_net-next/issues/491
Reviewed-by: Mat Martineau <martineau@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://lore.kernel.org/r/20240524-upstream-net-20240524-selftests-mptcp-flaky-v1-4-a352362f3f8e@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Matthieu Baerts (NGI0) and committed by
Jakub Kicinski
38af56e6 8c06ac21

+2
+2
tools/testing/selftests/net/mptcp/mptcp_join.sh
··· 3101 3101 { 3102 3102 # single subflow 3103 3103 if reset_with_fail "Infinite map" 1; then 3104 + MPTCP_LIB_SUBTEST_FLAKY=1 3104 3105 test_linkfail=128 \ 3105 3106 run_tests $ns1 $ns2 10.0.1.1 3106 3107 chk_join_nr 0 0 0 +1 +0 1 0 1 "$(pedit_action_pkts)" ··· 3110 3109 3111 3110 # multiple subflows 3112 3111 if reset_with_fail "MP_FAIL MP_RST" 2; then 3112 + MPTCP_LIB_SUBTEST_FLAKY=1 3113 3113 tc -n $ns2 qdisc add dev ns2eth1 root netem rate 1mbit delay 5ms 3114 3114 pm_nl_set_limits $ns1 0 1 3115 3115 pm_nl_set_limits $ns2 0 1