Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/amdgpu/vcn: Return void from the stop_dbg_mode

There is no point in returning an int here. It only returns 0 which
the caller never uses. Therefore return void and remove the unnecessary
assignment.

Addresses-Coverity: 1504988 ("Unused value")
Fixes: 8da1170a16e4 ("drm/amdgpu: add VCN4 ip block support")
Reviewed-by: Ruijing Dong <ruijing.dong@amd.com>
Suggested-by: Ruijing Dong <ruijing.dong@amd.com>
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Khalid Masum <khalid.masum.92@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

authored by

Khalid Masum and committed by
Alex Deucher
385bf5a8 bf7f7efb

+2 -3
+2 -3
drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
··· 1115 1115 * 1116 1116 * Stop VCN block with dpg mode 1117 1117 */ 1118 - static int vcn_v4_0_stop_dpg_mode(struct amdgpu_device *adev, int inst_idx) 1118 + static void vcn_v4_0_stop_dpg_mode(struct amdgpu_device *adev, int inst_idx) 1119 1119 { 1120 1120 uint32_t tmp; 1121 1121 ··· 1133 1133 /* disable dynamic power gating mode */ 1134 1134 WREG32_P(SOC15_REG_OFFSET(VCN, inst_idx, regUVD_POWER_STATUS), 0, 1135 1135 ~UVD_POWER_STATUS__UVD_PG_MODE_MASK); 1136 - return 0; 1137 1136 } 1138 1137 1139 1138 /** ··· 1153 1154 fw_shared->sq.queue_mode |= FW_QUEUE_DPG_HOLD_OFF; 1154 1155 1155 1156 if (adev->pg_flags & AMD_PG_SUPPORT_VCN_DPG) { 1156 - r = vcn_v4_0_stop_dpg_mode(adev, i); 1157 + vcn_v4_0_stop_dpg_mode(adev, i); 1157 1158 continue; 1158 1159 } 1159 1160