Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[PATCH] Scheduled removal of SA_xxx interrupt flags fixups

The obsolete SA_xxx interrupt flags have been used despite the scheduled
removal. Fixup the remaining users.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Ingo Molnar <mingo@elte.hu>
Cc: "Luck, Tony" <tony.luck@intel.com>
Cc: Roman Zippel <zippel@linux-m68k.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Jeff Garzik <jeff@garzik.org>
Cc: Wim Van Sebroeck <wim@iguana.be>
Cc: Roland Dreier <rolandd@cisco.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: James Bottomley <James.Bottomley@steeleye.com>
Cc: Greg KH <greg@kroah.com>
Cc: Dave Airlie <airlied@linux.ie>
Cc: James Simmons <jsimmons@infradead.org>
Cc: "Antonino A. Daplas" <adaplas@pol.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Thomas Gleixner and committed by
Linus Torvalds
38515e90 3159f06d

+39 -38
+1 -1
arch/ia64/kernel/irq_ia64.c
··· 275 275 276 276 static struct irqaction resched_irqaction = { 277 277 .handler = dummy_handler, 278 - .flags = SA_INTERRUPT, 278 + .flags = IRQF_DISABLED, 279 279 .name = "resched" 280 280 }; 281 281 #endif
+1 -1
arch/m68k/atari/stdma.c
··· 174 174 void __init stdma_init(void) 175 175 { 176 176 stdma_isr = NULL; 177 - request_irq(IRQ_MFP_FDC, stdma_int, IRQ_TYPE_SLOW | SA_SHIRQ, 177 + request_irq(IRQ_MFP_FDC, stdma_int, IRQ_TYPE_SLOW | IRQF_SHARED, 178 178 "ST-DMA: floppy/ACSI/IDE/Falcon-SCSI", stdma_int); 179 179 } 180 180
+1 -1
arch/ppc/syslib/i8259.c
··· 154 154 155 155 static struct irqaction i8259_irqaction = { 156 156 .handler = no_action, 157 - .flags = SA_INTERRUPT, 157 + .flags = IRQF_DISABLED, 158 158 .mask = CPU_MASK_NONE, 159 159 .name = "82c59 secondary cascade", 160 160 };
+1 -1
drivers/ata/pata_mpiix.c
··· 241 241 probe.port_ops = &mpiix_port_ops; 242 242 probe.sht = &mpiix_sht; 243 243 probe.pio_mask = 0x1F; 244 - probe.irq_flags = SA_SHIRQ; 244 + probe.irq_flags = IRQF_SHARED; 245 245 probe.port_flags = ATA_FLAG_SLAVE_POSS | ATA_FLAG_SRST; 246 246 probe.n_ports = 1; 247 247
+1 -1
drivers/ata/pata_pcmcia.c
··· 264 264 ae.n_ports = 1; 265 265 ae.pio_mask = 1; /* ISA so PIO 0 cycles */ 266 266 ae.irq = pdev->irq.AssignedIRQ; 267 - ae.irq_flags = SA_SHIRQ; 267 + ae.irq_flags = IRQF_SHARED; 268 268 ae.port_flags = ATA_FLAG_SLAVE_POSS | ATA_FLAG_SRST; 269 269 ae.port[0].cmd_addr = io_addr; 270 270 ae.port[0].altstatus_addr = ctl_addr;
+1 -1
drivers/ata/pata_pdc2027x.c
··· 796 796 probe_ent->port_ops = pdc2027x_port_info[board_idx].port_ops; 797 797 798 798 probe_ent->irq = pdev->irq; 799 - probe_ent->irq_flags = SA_SHIRQ; 799 + probe_ent->irq_flags = IRQF_SHARED; 800 800 probe_ent->iomap = pcim_iomap_table(pdev); 801 801 802 802 mmio_base = probe_ent->iomap[PDC_MMIO_BAR];
+1 -1
drivers/char/watchdog/rm9k_wdt.c
··· 192 192 locked = 0; 193 193 } 194 194 195 - res = request_irq(wd_irq, wdt_gpi_irqhdl, SA_SHIRQ | SA_INTERRUPT, 195 + res = request_irq(wd_irq, wdt_gpi_irqhdl, IRQF_SHARED | IRQF_DISABLED, 196 196 wdt_gpi_name, &miscdev); 197 197 if (unlikely(res)) 198 198 return res;
+1 -1
drivers/infiniband/hw/amso1100/c2.c
··· 1073 1073 0xffffc000) / sizeof(struct c2_rxp_desc); 1074 1074 1075 1075 /* Request an interrupt line for the driver */ 1076 - ret = request_irq(pcidev->irq, c2_interrupt, SA_SHIRQ, DRV_NAME, c2dev); 1076 + ret = request_irq(pcidev->irq, c2_interrupt, IRQF_SHARED, DRV_NAME, c2dev); 1077 1077 if (ret) { 1078 1078 printk(KERN_ERR PFX "%s: requested IRQ %u is busy\n", 1079 1079 pci_name(pcidev), pcidev->irq);
+2 -2
drivers/infiniband/hw/ehca/ehca_eq.c
··· 122 122 /* register interrupt handlers and initialize work queues */ 123 123 if (type == EHCA_EQ) { 124 124 ret = ibmebus_request_irq(NULL, eq->ist, ehca_interrupt_eq, 125 - SA_INTERRUPT, "ehca_eq", 125 + IRQF_DISABLED, "ehca_eq", 126 126 (void *)shca); 127 127 if (ret < 0) 128 128 ehca_err(ib_dev, "Can't map interrupt handler."); ··· 130 130 tasklet_init(&eq->interrupt_task, ehca_tasklet_eq, (long)shca); 131 131 } else if (type == EHCA_NEQ) { 132 132 ret = ibmebus_request_irq(NULL, eq->ist, ehca_interrupt_neq, 133 - SA_INTERRUPT, "ehca_neq", 133 + IRQF_DISABLED, "ehca_neq", 134 134 (void *)shca); 135 135 if (ret < 0) 136 136 ehca_err(ib_dev, "Can't map interrupt handler.");
+1 -1
drivers/misc/tifm_7xx1.c
··· 367 367 if (!fm->addr) 368 368 goto err_out_free; 369 369 370 - rc = request_irq(dev->irq, tifm_7xx1_isr, SA_SHIRQ, DRIVER_NAME, fm); 370 + rc = request_irq(dev->irq, tifm_7xx1_isr, IRQF_SHARED, DRIVER_NAME, fm); 371 371 if (rc) 372 372 goto err_out_unmap; 373 373
+1 -1
drivers/net/7990.c
··· 500 500 int res; 501 501 502 502 /* Install the Interrupt handler. Or we could shunt this out to specific drivers? */ 503 - if (request_irq(lp->irq, lance_interrupt, SA_SHIRQ, lp->name, dev)) 503 + if (request_irq(lp->irq, lance_interrupt, IRQF_SHARED, lp->name, dev)) 504 504 return -EAGAIN; 505 505 506 506 res = lance_reset(dev);
+4 -4
drivers/net/ehea/ehea_main.c
··· 882 882 , "%s-recv%d", dev->name, i); 883 883 ret = ibmebus_request_irq(NULL, pr->recv_eq->attr.ist1, 884 884 ehea_recv_irq_handler, 885 - SA_INTERRUPT, pr->int_recv_name, pr); 885 + IRQF_DISABLED, pr->int_recv_name, pr); 886 886 if (ret) { 887 887 ehea_error("failed registering irq for ehea_recv_int:" 888 888 "port_res_nr:%d, ist=%X", i, ··· 899 899 900 900 ret = ibmebus_request_irq(NULL, port->qp_eq->attr.ist1, 901 901 ehea_qp_aff_irq_handler, 902 - SA_INTERRUPT, port->int_aff_name, port); 902 + IRQF_DISABLED, port->int_aff_name, port); 903 903 if (ret) { 904 904 ehea_error("failed registering irq for qp_aff_irq_handler:" 905 905 "ist=%X", port->qp_eq->attr.ist1); ··· 916 916 "%s-send%d", dev->name, i); 917 917 ret = ibmebus_request_irq(NULL, pr->send_eq->attr.ist1, 918 918 ehea_send_irq_handler, 919 - SA_INTERRUPT, pr->int_send_name, 919 + IRQF_DISABLED, pr->int_send_name, 920 920 pr); 921 921 if (ret) { 922 922 ehea_error("failed registering irq for ehea_send " ··· 2539 2539 (unsigned long)adapter); 2540 2540 2541 2541 ret = ibmebus_request_irq(NULL, adapter->neq->attr.ist1, 2542 - ehea_interrupt_neq, SA_INTERRUPT, 2542 + ehea_interrupt_neq, IRQF_DISABLED, 2543 2543 "ehea_neq", adapter); 2544 2544 if (ret) { 2545 2545 dev_err(&dev->ofdev.dev, "requesting NEQ IRQ failed");
+1 -1
drivers/net/macb.c
··· 1077 1077 } 1078 1078 1079 1079 dev->irq = platform_get_irq(pdev, 0); 1080 - err = request_irq(dev->irq, macb_interrupt, SA_SAMPLE_RANDOM, 1080 + err = request_irq(dev->irq, macb_interrupt, IRQF_SAMPLE_RANDOM, 1081 1081 dev->name, dev); 1082 1082 if (err) { 1083 1083 printk(KERN_ERR
+2 -2
drivers/net/netxen/netxen_nic_main.c
··· 619 619 } 620 620 adapter->irq = adapter->ahw.pdev->irq; 621 621 err = request_irq(adapter->ahw.pdev->irq, &netxen_intr, 622 - SA_SHIRQ | SA_SAMPLE_RANDOM, netdev->name, 623 - adapter); 622 + IRQF_SHARED | IRQF_SAMPLE_RANDOM, 623 + netdev->name, adapter); 624 624 if (err) { 625 625 printk(KERN_ERR "request_irq failed with: %d\n", err); 626 626 netxen_free_hw_resources(adapter);
+2 -2
drivers/net/qla3xxx.c
··· 3228 3228 { 3229 3229 struct net_device *ndev = qdev->ndev; 3230 3230 int err; 3231 - unsigned long irq_flags = SA_SAMPLE_RANDOM | SA_SHIRQ; 3231 + unsigned long irq_flags = IRQF_SAMPLE_RANDOM | IRQF_SHARED; 3232 3232 unsigned long hw_flags; 3233 3233 3234 3234 if (ql_alloc_mem_resources(qdev)) { ··· 3247 3247 } else { 3248 3248 printk(KERN_INFO PFX "%s: MSI Enabled...\n", qdev->ndev->name); 3249 3249 set_bit(QL_MSI_ENABLED,&qdev->flags); 3250 - irq_flags &= ~SA_SHIRQ; 3250 + irq_flags &= ~IRQF_SHARED; 3251 3251 } 3252 3252 } 3253 3253
+2 -2
drivers/net/ucc_geth.c
··· 3939 3939 /* Grab the PHY interrupt, if necessary/possible */ 3940 3940 if (ugeth->ug_info->board_flags & FSL_UGETH_BRD_HAS_PHY_INTR) { 3941 3941 if (request_irq(ugeth->ug_info->phy_interrupt, 3942 - phy_interrupt, 3943 - SA_SHIRQ, "phy_interrupt", mii_info->dev) < 0) { 3942 + phy_interrupt, IRQF_SHARED, 3943 + "phy_interrupt", mii_info->dev) < 0) { 3944 3944 ugeth_err("%s: Can't get IRQ %d (PHY)", 3945 3945 mii_info->dev->name, 3946 3946 ugeth->ug_info->phy_interrupt);
+1 -1
drivers/pci/pcie/aer/aerdrv.c
··· 220 220 } 221 221 222 222 /* Request IRQ ISR */ 223 - if ((status = request_irq(dev->irq, aer_irq, SA_SHIRQ, "aerdrv", 223 + if ((status = request_irq(dev->irq, aer_irq, IRQF_SHARED, "aerdrv", 224 224 dev))) { 225 225 printk(KERN_DEBUG "%s: Request ISR fails on PCIE device[%s]\n", 226 226 __FUNCTION__, device->bus_id);
+2 -2
drivers/rtc/rtc-omap.c
··· 417 417 rtc_write(OMAP_RTC_STATUS_ALARM, OMAP_RTC_STATUS_REG); 418 418 419 419 /* handle periodic and alarm irqs */ 420 - if (request_irq(omap_rtc_timer, rtc_irq, SA_INTERRUPT, 420 + if (request_irq(omap_rtc_timer, rtc_irq, IRQF_DISABLED, 421 421 rtc->class_dev.class_id, &rtc->class_dev)) { 422 422 pr_debug("%s: RTC timer interrupt IRQ%d already claimed\n", 423 423 pdev->name, omap_rtc_timer); 424 424 goto fail0; 425 425 } 426 - if (request_irq(omap_rtc_alarm, rtc_irq, SA_INTERRUPT, 426 + if (request_irq(omap_rtc_alarm, rtc_irq, IRQF_DISABLED, 427 427 rtc->class_dev.class_id, &rtc->class_dev)) { 428 428 pr_debug("%s: RTC alarm interrupt IRQ%d already claimed\n", 429 429 pdev->name, omap_rtc_alarm);
+2 -2
drivers/rtc/rtc-s3c.c
··· 350 350 int ret; 351 351 352 352 ret = request_irq(s3c_rtc_alarmno, s3c_rtc_alarmirq, 353 - SA_INTERRUPT, "s3c2410-rtc alarm", rtc_dev); 353 + IRQF_DISABLED, "s3c2410-rtc alarm", rtc_dev); 354 354 355 355 if (ret) { 356 356 dev_err(dev, "IRQ%d error %d\n", s3c_rtc_alarmno, ret); ··· 358 358 } 359 359 360 360 ret = request_irq(s3c_rtc_tickno, s3c_rtc_tickirq, 361 - SA_INTERRUPT, "s3c2410-rtc tick", rtc_dev); 361 + IRQF_DISABLED, "s3c2410-rtc tick", rtc_dev); 362 362 363 363 if (ret) { 364 364 dev_err(dev, "IRQ%d error %d\n", s3c_rtc_tickno, ret);
+1 -1
drivers/scsi/aic94xx/aic94xx_init.c
··· 653 653 if (use_msi) 654 654 pci_enable_msi(asd_ha->pcidev); 655 655 656 - err = request_irq(asd_ha->pcidev->irq, asd_hw_isr, SA_SHIRQ, 656 + err = request_irq(asd_ha->pcidev->irq, asd_hw_isr, IRQF_SHARED, 657 657 ASD_DRIVER_NAME, asd_ha); 658 658 if (err) { 659 659 asd_printk("couldn't get irq %d for %s\n",
+1 -1
drivers/scsi/arcmsr/arcmsr_hba.c
··· 322 322 goto out_iounmap; 323 323 324 324 error = request_irq(pdev->irq, arcmsr_do_interrupt, 325 - SA_INTERRUPT | SA_SHIRQ, "arcmsr", acb); 325 + IRQF_DISABLED | IRQF_SHARED, "arcmsr", acb); 326 326 if (error) 327 327 goto out_free_ccb_pool; 328 328
+1 -1
drivers/scsi/ibmvscsi/ibmvstgt.c
··· 580 580 } 581 581 582 582 err = request_irq(vport->dma_dev->irq, &ibmvstgt_interrupt, 583 - SA_INTERRUPT, "ibmvstgt", target); 583 + IRQF_DISABLED, "ibmvstgt", target); 584 584 if (err) 585 585 goto req_irq_failed; 586 586
+1 -1
drivers/scsi/qla4xxx/ql4_os.c
··· 1270 1270 INIT_WORK(&ha->dpc_work, qla4xxx_do_dpc); 1271 1271 1272 1272 ret = request_irq(pdev->irq, qla4xxx_intr_handler, 1273 - SA_INTERRUPT|SA_SHIRQ, "qla4xxx", ha); 1273 + IRQF_DISABLED | IRQF_SHARED, "qla4xxx", ha); 1274 1274 if (ret) { 1275 1275 dev_warn(&ha->pdev->dev, "Failed to reserve interrupt %d" 1276 1276 " already in use.\n", pdev->irq);
+1 -1
drivers/usb/gadget/pxa2xx_udc.c
··· 2613 2613 #endif 2614 2614 if (vbus_irq) { 2615 2615 retval = request_irq(vbus_irq, udc_vbus_irq, 2616 - SA_INTERRUPT | SA_SAMPLE_RANDOM, 2616 + IRQF_DISABLED | IRQF_SAMPLE_RANDOM, 2617 2617 driver_name, dev); 2618 2618 if (retval != 0) { 2619 2619 printk(KERN_ERR "%s: can't get irq %i, err %d\n",
+1 -1
drivers/usb/host/ohci-ep93xx.c
··· 78 78 79 79 ohci_hcd_init(hcd_to_ohci(hcd)); 80 80 81 - retval = usb_add_hcd(hcd, pdev->resource[1].start, SA_INTERRUPT); 81 + retval = usb_add_hcd(hcd, pdev->resource[1].start, IRQF_DISABLED); 82 82 if (retval == 0) 83 83 return retval; 84 84
+1 -1
drivers/usb/host/ohci-pnx4008.c
··· 421 421 ohci_hcd_init(ohci); 422 422 423 423 dev_info(&pdev->dev, "at 0x%p, irq %d\n", hcd->regs, hcd->irq); 424 - ret = usb_add_hcd(hcd, irq, SA_INTERRUPT); 424 + ret = usb_add_hcd(hcd, irq, IRQF_DISABLED); 425 425 if (ret == 0) 426 426 return ret; 427 427
+1 -1
drivers/usb/host/ohci-pnx8550.c
··· 107 107 108 108 ohci_hcd_init(hcd_to_ohci(hcd)); 109 109 110 - retval = usb_add_hcd(hcd, dev->resource[1].start, SA_INTERRUPT); 110 + retval = usb_add_hcd(hcd, dev->resource[1].start, IRQF_DISABLED); 111 111 if (retval == 0) 112 112 return retval; 113 113
+2 -1
drivers/video/intelfb/intelfbhw.c
··· 1990 1990 intelfbhw_enable_irq(struct intelfb_info *dinfo, int reenable) { 1991 1991 1992 1992 if (!test_and_set_bit(0, &dinfo->irq_flags)) { 1993 - if (request_irq(dinfo->pdev->irq, intelfbhw_irq, SA_SHIRQ, "intelfb", dinfo)) { 1993 + if (request_irq(dinfo->pdev->irq, intelfbhw_irq, IRQF_SHARED, 1994 + "intelfb", dinfo)) { 1994 1995 clear_bit(0, &dinfo->irq_flags); 1995 1996 return -EINVAL; 1996 1997 }
+1 -1
kernel/irq/manage.c
··· 461 461 /* 462 462 * Lockdep wants atomic interrupt handlers: 463 463 */ 464 - irqflags |= SA_INTERRUPT; 464 + irqflags |= IRQF_DISABLED; 465 465 #endif 466 466 /* 467 467 * Sanity-check: shared interrupts must pass in a real dev-ID,