Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

irqchip/alpine-msi: Fix freeing of interrupts on allocation error path

The alpine-msi driver has an interesting allocation error handling,
where it frees the same interrupts repeatedly. Hilarity follows.

This code is probably never executed, but let's fix it nonetheless.

Fixes: e6b78f2c3e14 ("irqchip: Add the Alpine MSIX interrupt controller")
Signed-off-by: Marc Zyngier <maz@kernel.org>
Reviewed-by: Antoine Tenart <atenart@kernel.org>
Cc: Tsahee Zidenberg <tsahee@annapurnalabs.com>
Cc: Antoine Tenart <atenart@kernel.org>
Link: https://lore.kernel.org/r/20201129135525.396671-1-maz@kernel.org

+1 -2
+1 -2
drivers/irqchip/irq-alpine-msi.c
··· 165 165 return 0; 166 166 167 167 err_sgi: 168 - while (--i >= 0) 169 - irq_domain_free_irqs_parent(domain, virq, i); 168 + irq_domain_free_irqs_parent(domain, virq, i - 1); 170 169 alpine_msix_free_sgi(priv, sgi, nr_irqs); 171 170 return err; 172 171 }