Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

phy: ingenic: use core driver model helper to handle probe errors

Use core driver model helper dev_err_probe() defined at
drivers/base/core.c in driver probe path to propagate errors.
standardize and improve the code of deferred probe error handling
using this helper for ingenic usb phy driver.
Inspired by,
commit a787e5400a1ce ("driver core: add device probe log helper")

Signed-off-by: Akhilesh Patil <akhilesh@ee.iitb.ac.in>
Cc: Andrzej Hajda <a.hajda@samsung.com>
Link: https://lore.kernel.org/r/aIIMW971BYsIk4As@bhairav-test.ee.iitb.ac.in
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Akhilesh Patil and committed by
Vinod Koul
38404274 ce489635

+2 -6
+2 -6
drivers/phy/ingenic/phy-ingenic-usb.c
··· 339 339 priv->clk = devm_clk_get(dev, NULL); 340 340 if (IS_ERR(priv->clk)) { 341 341 err = PTR_ERR(priv->clk); 342 - if (err != -EPROBE_DEFER) 343 - dev_err(dev, "Failed to get clock\n"); 344 - return err; 342 + return dev_err_probe(dev, err, "Failed to get clock\n"); 345 343 } 346 344 347 345 priv->vcc_supply = devm_regulator_get(dev, "vcc"); 348 346 if (IS_ERR(priv->vcc_supply)) { 349 347 err = PTR_ERR(priv->vcc_supply); 350 - if (err != -EPROBE_DEFER) 351 - dev_err(dev, "Failed to get regulator\n"); 352 - return err; 348 + return dev_err_probe(dev, err, "Failed to get regulator\n"); 353 349 } 354 350 355 351 priv->phy = devm_phy_create(dev, NULL, &ingenic_usb_phy_ops);