Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

perf tools: Fix handling read result using a signed variable

The function can return negative value, assigning it to unsigned
variable can cause memory corruption.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: kernel-janitors@vger.kernel.org
Link: http://lkml.kernel.org/r/1444122017-16856-1-git-send-email-a.hajda@samsung.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

authored by

Andrzej Hajda and committed by
Arnaldo Carvalho de Melo
38349665 1178bfd4

+2 -1
+2 -1
tools/perf/util/event.c
··· 67 67 char filename[PATH_MAX]; 68 68 char bf[4096]; 69 69 int fd; 70 - size_t size = 0, n; 70 + size_t size = 0; 71 + ssize_t n; 71 72 char *nl, *name, *tgids, *ppids; 72 73 73 74 *tgid = -1;