Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

kunit: string-stream-test: Avoid cast warning when testing gfp_t flags

Passing a gfp_t to KUNIT_EXPECT_EQ() causes a cast warning:

lib/kunit/string-stream-test.c:73:9: sparse: sparse: incorrect type in
initializer (different base types) expected long long right_value
got restricted gfp_t const __right

Avoid this by testing stream->gfp for the expected value and passing the
boolean result of this comparison to KUNIT_EXPECT_TRUE(), as was already
done a few lines above in string_stream_managed_init_test().

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Fixes: d1a0d699bfc0 ("kunit: string-stream: Add tests for freeing resource-managed string_stream")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202311181918.0mpCu2Xh-lkp@intel.com/
Reviewed-by: Rae Moar <rmoar@google.com>
Reviewed-by: David Gow <davidgow@google.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>

authored by

Richard Fitzgerald and committed by
Shuah Khan
37f0d37f a08d4d62

+1 -1
+1 -1
lib/kunit/string-stream-test.c
··· 72 72 73 73 KUNIT_EXPECT_EQ(test, stream->length, 0); 74 74 KUNIT_EXPECT_TRUE(test, list_empty(&stream->fragments)); 75 - KUNIT_EXPECT_EQ(test, stream->gfp, GFP_KERNEL); 75 + KUNIT_EXPECT_TRUE(test, (stream->gfp == GFP_KERNEL)); 76 76 KUNIT_EXPECT_FALSE(test, stream->append_newlines); 77 77 78 78 KUNIT_EXPECT_TRUE(test, string_stream_is_empty(stream));