tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

hinic: Use kmemdup instead of kzalloc and memcpy

Fixes coccicheck warnings:

drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c:452:17-24: WARNING opportunity for kmemdup
drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c:458:23-30: WARNING opportunity for kmemdup

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Zou Wei and committed by
David S. Miller 37ecb5b8 25979125

+3 -6
+3 -6
drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c
··· 449 449 return; 450 450 } 451 451 452 - rcv_mbox_temp = kzalloc(sizeof(*rcv_mbox_temp), GFP_KERNEL); 452 + rcv_mbox_temp = kmemdup(recv_mbox, sizeof(*rcv_mbox_temp), GFP_KERNEL); 453 453 if (!rcv_mbox_temp) 454 454 return; 455 455 456 - memcpy(rcv_mbox_temp, recv_mbox, sizeof(*rcv_mbox_temp)); 457 - 458 - rcv_mbox_temp->mbox = kzalloc(MBOX_MAX_BUF_SZ, GFP_KERNEL); 456 + rcv_mbox_temp->mbox = kmemdup(recv_mbox->mbox, MBOX_MAX_BUF_SZ, 457 + GFP_KERNEL); 459 458 if (!rcv_mbox_temp->mbox) 460 459 goto err_alloc_rcv_mbox_msg; 461 - 462 - memcpy(rcv_mbox_temp->mbox, recv_mbox->mbox, MBOX_MAX_BUF_SZ); 463 460 464 461 rcv_mbox_temp->buf_out = kzalloc(MBOX_MAX_BUF_SZ, GFP_KERNEL); 465 462 if (!rcv_mbox_temp->buf_out)