Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

video: Fix possible leak in of_get_videomode()

In case videomode_from_timings() fails in function of_get_videomode(), the
allocated display timing data is not freed in the exit path. Make sure that
display_timings_release() is called in any case. Detected by Coverity CID
1309681.

Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

authored by

Christian Engelmayer and committed by
Tomi Valkeinen
37b617f9 9e6e35ed

+1 -3
+1 -3
drivers/video/of_videomode.c
··· 44 44 index = disp->native_mode; 45 45 46 46 ret = videomode_from_timings(disp, vm, index); 47 - if (ret) 48 - return ret; 49 47 50 48 display_timings_release(disp); 51 49 52 - return 0; 50 + return ret; 53 51 } 54 52 EXPORT_SYMBOL_GPL(of_get_videomode);