tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

dmaengine: ipu: use return value of request_irq

Commit - 653e67f7e5: "dmaengine: inherit debug settings from the subsystem
for subdirectories" introduced debug option for subdirectories too
This exposed issue with ipu driver not using return value

For now just warn users about it

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>

Vinod Koul 37a746aa e2f9922a

+10 -4
+10 -4
drivers/dma/ipu/ipu_idmac.c
··· 1532 1532 #ifdef DEBUG 1533 1533 if (chan->chan_id == IDMAC_IC_7) { 1534 1534 ic_sof = ipu_irq_map(69); 1535 - if (ic_sof > 0) 1536 - request_irq(ic_sof, ic_sof_irq, 0, "IC SOF", ichan); 1535 + if (ic_sof > 0) { 1536 + ret = request_irq(ic_sof, ic_sof_irq, 0, "IC SOF", ichan); 1537 + if (ret) 1538 + dev_err(&chan->dev->device, "request irq failed for IC SOF"); 1539 + } 1537 1540 ic_eof = ipu_irq_map(70); 1538 - if (ic_eof > 0) 1539 - request_irq(ic_eof, ic_eof_irq, 0, "IC EOF", ichan); 1541 + if (ic_eof > 0) { 1542 + ret = request_irq(ic_eof, ic_eof_irq, 0, "IC EOF", ichan); 1543 + if (ret) 1544 + dev_err(&chan->dev->device, "request irq failed for IC EOF"); 1545 + } 1540 1546 } 1541 1547 #endif 1542 1548