Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

spi/bcm63xx-hspi: fix error return code in bcm63xx_hsspi_probe()

platform_get_irq() returns an error code, but the spi-bcm63xx-hsspi
driver ignores it and always returns -ENXIO. This is not correct and,
prevents -EPROBE_DEFER from being propagated properly.

Notice that platform_get_irq() no longer returns 0 on error:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af

Print and propagate the return value of platform_get_irq on failure.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Gustavo A. R. Silva and committed by
Mark Brown
378da4a6 ba8afe94

+2 -2
+2 -2
drivers/spi/spi-bcm63xx-hsspi.c
··· 338 338 339 339 irq = platform_get_irq(pdev, 0); 340 340 if (irq < 0) { 341 - dev_err(dev, "no irq\n"); 342 - return -ENXIO; 341 + dev_err(dev, "no irq: %d\n", irq); 342 + return irq; 343 343 } 344 344 345 345 res_mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);