Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

sctp: remove unnecessary NULL checks in sctp_enqueue_event()

After commit 178ca044aa60 ("sctp: Make sctp_enqueue_event tak an
skb list."), skb_list cannot be NULL.

Detected using the static analysis tool - Svace.
Signed-off-by: Alexey Kodanev <aleksei.kodanev@bell-sw.com>
Reviewed-by: Xin Long <lucien.xin@gmail.com>
Link: https://lore.kernel.org/r/20221019180735.161388-3-aleksei.kodanev@bell-sw.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Alexey Kodanev and committed by
Jakub Kicinski
377eb9aa b66aeddb

+3 -9
+3 -9
net/sctp/stream_interleave.c
··· 490 490 if (!sctp_ulpevent_is_enabled(event, ulpq->asoc->subscribe)) 491 491 goto out_free; 492 492 493 - if (skb_list) 494 - skb_queue_splice_tail_init(skb_list, 495 - &sk->sk_receive_queue); 496 - else 497 - __skb_queue_tail(&sk->sk_receive_queue, skb); 493 + skb_queue_splice_tail_init(skb_list, 494 + &sk->sk_receive_queue); 498 495 499 496 if (!sp->data_ready_signalled) { 500 497 sp->data_ready_signalled = 1; ··· 501 504 return 1; 502 505 503 506 out_free: 504 - if (skb_list) 505 - sctp_queue_purge_ulpevents(skb_list); 506 - else 507 - sctp_ulpevent_free(event); 507 + sctp_queue_purge_ulpevents(skb_list); 508 508 509 509 return 0; 510 510 }