Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

sparc32: fix sparse warnings in leon_pci_grpci2.c

Fix following warnings:
leon_pci_grpci2.c:218:1: warning: symbol 'grpci2_dev_lock' was not declared. Should it be static?
leon_pci_grpci2.c:219:20: warning: symbol 'grpci2priv' was not declared. Should it be static?
leon_pci_grpci2.c:221:5: warning: symbol 'grpci2_map_irq' was not declared. Should it be static?
leon_pci_grpci2.c:564:6: warning: symbol 'grpci2_hw_init' was not declared. Should it be
static?

+ a lot of these:
leon_pci_grpci2.c:252:9: warning: incorrect type in argument 1 (different address spaces)

Declare the symbols static as they are only used in this file.
Added missing __iomem annotations.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Daniel Hellstrom <daniel@gaisler.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Sam Ravnborg and committed by
David S. Miller
3731e199 d65f0cd3

+9 -9
+9 -9
arch/sparc/kernel/leon_pci_grpci2.c
··· 191 191 192 192 struct grpci2_priv { 193 193 struct leon_pci_info info; /* must be on top of this structure */ 194 - struct grpci2_regs *regs; 194 + struct grpci2_regs __iomem *regs; 195 195 char irq; 196 196 char irq_mode; /* IRQ Mode from CAPSTS REG */ 197 197 char bt_enabled; ··· 215 215 struct grpci2_barcfg tgtbars[6]; 216 216 }; 217 217 218 - DEFINE_SPINLOCK(grpci2_dev_lock); 219 - struct grpci2_priv *grpci2priv; 218 + static DEFINE_SPINLOCK(grpci2_dev_lock); 219 + static struct grpci2_priv *grpci2priv; 220 220 221 - int grpci2_map_irq(const struct pci_dev *dev, u8 slot, u8 pin) 221 + static int grpci2_map_irq(const struct pci_dev *dev, u8 slot, u8 pin) 222 222 { 223 223 struct grpci2_priv *priv = dev->bus->sysdata; 224 224 int irq_group; ··· 561 561 return virq; 562 562 } 563 563 564 - void grpci2_hw_init(struct grpci2_priv *priv) 564 + static void grpci2_hw_init(struct grpci2_priv *priv) 565 565 { 566 566 u32 ahbadr, pciadr, bar_sz, capptr, io_map, data; 567 - struct grpci2_regs *regs = priv->regs; 567 + struct grpci2_regs __iomem *regs = priv->regs; 568 568 int i; 569 569 struct grpci2_barcfg *barcfg = priv->tgtbars; 570 570 ··· 655 655 static irqreturn_t grpci2_err_interrupt(int irq, void *arg) 656 656 { 657 657 struct grpci2_priv *priv = arg; 658 - struct grpci2_regs *regs = priv->regs; 658 + struct grpci2_regs __iomem *regs = priv->regs; 659 659 unsigned int status; 660 660 661 661 status = REGLOAD(regs->sts_cap); ··· 682 682 683 683 static int grpci2_of_probe(struct platform_device *ofdev) 684 684 { 685 - struct grpci2_regs *regs; 685 + struct grpci2_regs __iomem *regs; 686 686 struct grpci2_priv *priv; 687 687 int err, i, len; 688 688 const int *tmp; ··· 878 878 release_resource(&priv->info.mem_space); 879 879 err3: 880 880 err = -ENOMEM; 881 - iounmap((void *)priv->pci_io_va); 881 + iounmap((void __iomem *)priv->pci_io_va); 882 882 err2: 883 883 kfree(priv); 884 884 err1: