Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

bcma: convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://msgid.link/a92e4b2f7aace64a1e3a91af7974a6982700a18f.1709886922.git.u.kleine-koenig@pengutronix.de

authored by

Uwe Kleine-König and committed by
Kalle Valo
370e6231 316f790e

+2 -4
+2 -4
drivers/bcma/host_soc.c
··· 240 240 return err; 241 241 } 242 242 243 - static int bcma_host_soc_remove(struct platform_device *pdev) 243 + static void bcma_host_soc_remove(struct platform_device *pdev) 244 244 { 245 245 struct bcma_bus *bus = platform_get_drvdata(pdev); 246 246 247 247 bcma_bus_unregister(bus); 248 248 iounmap(bus->mmio); 249 249 platform_set_drvdata(pdev, NULL); 250 - 251 - return 0; 252 250 } 253 251 254 252 static const struct of_device_id bcma_host_soc_of_match[] = { ··· 261 263 .of_match_table = bcma_host_soc_of_match, 262 264 }, 263 265 .probe = bcma_host_soc_probe, 264 - .remove = bcma_host_soc_remove, 266 + .remove_new = bcma_host_soc_remove, 265 267 }; 266 268 267 269 int __init bcma_host_soc_register_driver(void)