Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: bridge: Fix uninitialized error in br_fdb_sync_static()

With gcc-4.1.2.:

net/bridge/br_fdb.c: In function ‘br_fdb_sync_static’:
net/bridge/br_fdb.c:996: warning: ‘err’ may be used uninitialized in this function

Indeed, if the list is empty, err will be uninitialized, and will be
propagated up as the function return value.

Fix this by preinitializing err to zero.

Fixes: eb7935830d00b9e0 ("net: bridge: use rhashtable for fdbs")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Geert Uytterhoeven and committed by
David S. Miller
367dc658 9382fe71

+1 -1
+1 -1
net/bridge/br_fdb.c
··· 993 993 int br_fdb_sync_static(struct net_bridge *br, struct net_bridge_port *p) 994 994 { 995 995 struct net_bridge_fdb_entry *f, *tmp; 996 - int err; 996 + int err = 0; 997 997 998 998 ASSERT_RTNL(); 999 999