Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

media: davinci: don't override the error code

As warned by Coverity:
CID 1415211 (#1 of 1): Unused value (UNUSED_VALUE)assigned_value:
Assigning value -22 to ret here, but that stored value is
overwritten before it can be used.

On all cases where the there's a goto 'unlock_out' or 'streamof',
ret was filled with a non-sero value. It toesn't make sense to override
such error code with a videobuf_streamoff() error.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

authored by

Mauro Carvalho Chehab and committed by
Mauro Carvalho Chehab
366b4010 fd901b6e

+1 -1
+1 -1
drivers/media/platform/davinci/vpfe_capture.c
··· 1509 1509 unlock_out: 1510 1510 mutex_unlock(&vpfe_dev->lock); 1511 1511 streamoff: 1512 - ret = videobuf_streamoff(&vpfe_dev->buffer_queue); 1512 + videobuf_streamoff(&vpfe_dev->buffer_queue); 1513 1513 return ret; 1514 1514 } 1515 1515