Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

staging:iio:ad9951: Use spi_sync_transfer()

Use the spi_sync_transfer() helper function instead of open-coding it. Makes the
code a bit shorter.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>

authored by

Lars-Peter Clausen and committed by
Jonathan Cameron
3658a71b 630e7377

+6 -20
+6 -20
drivers/staging/iio/frequency/ad9951.c
··· 60 60 const char *buf, 61 61 size_t len) 62 62 { 63 - struct spi_message msg; 64 63 struct spi_transfer xfer; 65 64 int ret; 66 65 struct ad9951_config *config = (struct ad9951_config *)buf; ··· 70 71 xfer.tx_buf = &config->asf[0]; 71 72 mutex_lock(&st->lock); 72 73 73 - spi_message_init(&msg); 74 - spi_message_add_tail(&xfer, &msg); 75 - ret = spi_sync(st->sdev, &msg); 74 + ret = spi_sync_transfer(st->sdev, &xfer, 1); 76 75 if (ret) 77 76 goto error_ret; 78 77 79 78 xfer.len = 2; 80 79 xfer.tx_buf = &config->arr[0]; 81 80 82 - spi_message_init(&msg); 83 - spi_message_add_tail(&xfer, &msg); 84 - ret = spi_sync(st->sdev, &msg); 81 + ret = spi_sync_transfer(st->sdev, &xfer, 1); 85 82 if (ret) 86 83 goto error_ret; 87 84 88 85 xfer.len = 5; 89 86 xfer.tx_buf = &config->ftw0[0]; 90 87 91 - spi_message_init(&msg); 92 - spi_message_add_tail(&xfer, &msg); 93 - ret = spi_sync(st->sdev, &msg); 88 + ret = spi_sync_transfer(st->sdev, &xfer, 1); 94 89 if (ret) 95 90 goto error_ret; 96 91 97 92 xfer.len = 3; 98 93 xfer.tx_buf = &config->ftw1[0]; 99 94 100 - spi_message_init(&msg); 101 - spi_message_add_tail(&xfer, &msg); 102 - ret = spi_sync(st->sdev, &msg); 95 + ret = spi_sync_transfer(st->sdev, &xfer, 1); 103 96 if (ret) 104 97 goto error_ret; 105 98 error_ret: ··· 104 113 105 114 static void ad9951_init(struct ad9951_state *st) 106 115 { 107 - struct spi_message msg; 108 116 struct spi_transfer xfer; 109 117 int ret; 110 118 u8 cfr[5]; ··· 119 129 xfer.len = 5; 120 130 xfer.tx_buf = &cfr; 121 131 122 - spi_message_init(&msg); 123 - spi_message_add_tail(&xfer, &msg); 124 - ret = spi_sync(st->sdev, &msg); 132 + ret = spi_sync_transfer(st->sdev, &xfer, 1); 125 133 if (ret) 126 134 goto error_ret; 127 135 ··· 131 143 xfer.len = 4; 132 144 xfer.tx_buf = &cfr; 133 145 134 - spi_message_init(&msg); 135 - spi_message_add_tail(&xfer, &msg); 136 - ret = spi_sync(st->sdev, &msg); 146 + ret = spi_sync_transfer(st->sdev, &xfer, 1); 137 147 if (ret) 138 148 goto error_ret; 139 149