Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

scsi: fnic: make some symbols static

Fix the following sparse warning:

drivers/scsi/fnic/vnic_dev.c:257:5: warning: symbol 'vnic_dev_cmd1' was
not declared. Should it be static?
drivers/scsi/fnic/vnic_dev.c:319:5: warning: symbol 'vnic_dev_cmd2' was
not declared. Should it be static?
drivers/scsi/fnic/vnic_dev.c:414:5: warning: symbol
'vnic_dev_init_devcmd1' was not declared. Should it be static?
drivers/scsi/fnic/vnic_dev.c:425:5: warning: symbol
'vnic_dev_init_devcmd2' was not declared. Should it be static?
drivers/scsi/fnic/vnic_dev.c:495:6: warning: symbol
'vnic_dev_deinit_devcmd2' was not declared. Should it be static?
drivers/scsi/fnic/vnic_dev.c:506:5: warning: symbol
'vnic_dev_cmd_no_proxy' was not declared. Should it be static?

Link: https://lore.kernel.org/r/20200415093809.9365-1-yanaijie@huawei.com
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Jason Yan and committed by
Martin K. Petersen
363f4d93 1e4ffb83

+6 -6
+6 -6
drivers/scsi/fnic/vnic_dev.c
··· 254 254 } 255 255 } 256 256 257 - int vnic_dev_cmd1(struct vnic_dev *vdev, enum vnic_devcmd_cmd cmd, int wait) 257 + static int vnic_dev_cmd1(struct vnic_dev *vdev, enum vnic_devcmd_cmd cmd, int wait) 258 258 { 259 259 struct vnic_devcmd __iomem *devcmd = vdev->devcmd; 260 260 int delay; ··· 316 316 return -ETIMEDOUT; 317 317 } 318 318 319 - int vnic_dev_cmd2(struct vnic_dev *vdev, enum vnic_devcmd_cmd cmd, 319 + static int vnic_dev_cmd2(struct vnic_dev *vdev, enum vnic_devcmd_cmd cmd, 320 320 int wait) 321 321 { 322 322 struct devcmd2_controller *dc2c = vdev->devcmd2; ··· 411 411 } 412 412 413 413 414 - int vnic_dev_init_devcmd1(struct vnic_dev *vdev) 414 + static int vnic_dev_init_devcmd1(struct vnic_dev *vdev) 415 415 { 416 416 vdev->devcmd = vnic_dev_get_res(vdev, RES_TYPE_DEVCMD, 0); 417 417 if (!vdev->devcmd) ··· 422 422 } 423 423 424 424 425 - int vnic_dev_init_devcmd2(struct vnic_dev *vdev) 425 + static int vnic_dev_init_devcmd2(struct vnic_dev *vdev) 426 426 { 427 427 int err; 428 428 unsigned int fetch_index; ··· 492 492 } 493 493 494 494 495 - void vnic_dev_deinit_devcmd2(struct vnic_dev *vdev) 495 + static void vnic_dev_deinit_devcmd2(struct vnic_dev *vdev) 496 496 { 497 497 vnic_dev_free_desc_ring(vdev, &vdev->devcmd2->results_ring); 498 498 vnic_wq_disable(&vdev->devcmd2->wq); ··· 503 503 } 504 504 505 505 506 - int vnic_dev_cmd_no_proxy(struct vnic_dev *vdev, 506 + static int vnic_dev_cmd_no_proxy(struct vnic_dev *vdev, 507 507 enum vnic_devcmd_cmd cmd, u64 *a0, u64 *a1, int wait) 508 508 { 509 509 int err;