e1000e: balance semaphore put/get for 82573

Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

kernel os linux

Steven (cc-ed) noticed an imbalance in semaphore put/get for
82573-based NICs. Don't we need something like the following
(untested) patch?

Signed-off-by: Steven La <sla@riverbed.com>
Acked-by: Arthur Kepner <akepner@riverbed.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Steven La and committed by

David S. Miller 12 years ago 35fdb94b d7064f4c

1 changed file

expand all

drivers

net

ethernet

intel

e1000e

82571.c

drivers/net/ethernet/intel/e1000e/82571.c

··· 1011 1011 1012 1012 /* Must release MDIO ownership and mutex after MAC reset. */ 1013 1013 switch (hw->mac.type) { 1014 + case e1000_82573: 1015 + /* Release mutex only if the hw semaphore is acquired */ 1016 + if (!ret_val) 1017 + e1000_put_hw_semaphore_82573(hw); 1018 + break; 1014 1019 case e1000_82574: 1015 1020 case e1000_82583: 1016 1021 /* Release mutex only if the hw semaphore is acquired */